Bug 174163 - [api] Make tm.terminal.control package internal
Summary: [api] Make tm.terminal.control package internal
Status: CLOSED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 1.0.1   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 2.0   Edit
Assignee: Michael Scharf CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks: 170922
  Show dependency tree
 
Reported: 2007-02-14 09:17 EST by Martin Oberhuber CLA
Modified: 2008-08-13 13:16 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2007-02-14 09:17:49 EST 
The package org.eclipse.tm.terminal.control contains classes which are only used by the tm.terminal.view. The API for this is not yet in a state to be made public. Therefore, this package should be made "internal" and exported with ;x-friends="org.eclipse.tm.terminal.view"

org.eclipse.tm.terminal.control  
   --> org.eclipse.tm.internal.terminal.control
org.eclipse.tm.terminal.internal.control 
   --> org.eclipse.tm.internal.terminal.control.impl
Comment 1 Martin Oberhuber CLA 2007-02-14 09:24:09 EST 
Also, TerminalConnectorExtension should be moved into the internal package
org.eclipse.tm.internal.terminal.control

Another option for naming, (outlining that this is provisional API), could be
http://wiki.eclipse.org/index.php/Provisional_API_Guidelines#Package_naming_2

org.eclipse.tm.internal.provisional.terminal.control
org.eclipse.tm.internal.terminal.control.provisional

I don't like these too much and prefer going with the original proposal.
We might, however, want to add the EXPERIMENTAL paragraph to the Javadoc there:
http://wiki.eclipse.org/index.php/Provisional_API_Guidelines#Javadoc
Comment 2 Martin Oberhuber CLA 2007-02-21 05:45:38 EST 
Fixed with I20070219-1645
Comment 3 Martin Oberhuber CLA 2007-02-28 08:31:54 EST 
Verified with I20070223-0730
Comment 4 Martin Oberhuber CLA 2008-08-13 13:16:57 EDT 
[target cleanup] 2.0 M5 was the original target milestone for this bug