Description Ed Merks 2007-02-08 11:53:49 EST

I was asked to try out the new-to-M5 JDT diagnostic that uses data flow analysis to detect null pointer exceptions that will happen at runtime.  It found a problem with this code:

  if (info == null && !(info.fDocument instanceof IDiagramDocument))
    return;

which almost certainly should be expressed using || not &&:

  if (info == null || !(info.fDocument instanceof IDiagramDocument))
    return;

So it's probably a good idea to preemtively fix this.