Bug 173060 - [Manifest][Editors] Can't multi select in the extension tab of the plug-in editor
Summary: [Manifest][Editors] Can't multi select in the extension tab of the plug-in ed...
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: bartosz michalik CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed
Depends on:
Blocks:
 
Reported: 2007-02-06 09:29 EST by Pascal Rapicault CLA
Modified: 2007-11-20 11:24 EST (History)
4 users (show)

See Also:
baumanbr: review+


Attachments
MULTI and delete support proposal (7.41 KB, patch)
2007-10-23 05:59 EDT, bartosz michalik CLA
no flags Details | Diff
mylyn/context/zip (179.67 KB, application/octet-stream)
2007-10-23 05:59 EDT, bartosz michalik CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Pascal Rapicault CLA 2007-02-06 09:29:57 EST
I20070206-0010
To make the editing experience more pleasant, the extension section of the plugin editor should support multi selection to allow for easy removal of items.
Comment 1 Mike Pawlowski CLA 2007-07-09 11:46:13 EDT
This bug will affect how clipboard operations (copy, cut, paste) are enabled and performed.

The underlying code is already written for performing copy, cut and paste of multi-selected objects; however, the calculation of multiplicity constraints to determine enablement is made more complex. 

Just a heads up to take this into consideration when enabling multi-select.
Comment 2 Remy Suen CLA 2007-10-02 22:55:25 EDT
This is not as straightforward as just replacing SWT.SINGLE with SWT.MULTI (which by the way is in the createClient(Section, FormToolkit) method of the ExtensionsSection class). A mass delete is not wrapped as a single operation (although the current code does handle the multiselect gracefully per comment 1), so you need N undo operations equal to the N elements that you have removed.
Comment 3 bartosz michalik CLA 2007-10-23 03:51:21 EDT
I'm working on limited functionality right now. Multiselect that works only with remove option. MULTI is not applicable for move up/down but using it for copy/paste is to consider.
Comment 4 bartosz michalik CLA 2007-10-23 05:59:00 EDT
Created attachment 80937 [details]
MULTI and delete support proposal

as for now plugin.xml changes undo don't work (3.4M2) this is not addressed in this proposal. delete selected for multiple selection si supported, but copy/paste is not. selectAll added.
Comment 5 bartosz michalik CLA 2007-10-23 05:59:11 EDT
Created attachment 80938 [details]
mylyn/context/zip
Comment 6 Chris Aniszczyk CLA 2007-10-23 15:31:23 EDT
Do you think we could disable undo somehow when we delete multiple? I get a ton of NPEs and weird exceptions if I delete multiple things, start undoing, delete multiple things again, start undoing... lots of weird behavior when you keep repeating this process.
Comment 7 bartosz michalik CLA 2007-10-23 19:03:35 EDT
maybe i don't have test environment configured properly :| could you point me to the undo code (plugin) ?
Comment 8 Chris Aniszczyk CLA 2007-11-19 11:24:29 EST
Ok, just tried this and undo is disabled. I must've had a bad environment setup.
Comment 9 Chris Aniszczyk CLA 2007-11-19 11:56:02 EST
Thanks Bartosz, it's the small things like this that really help people :)
Comment 10 Brian Bauman CLA 2007-11-20 11:24:31 EST
Chris, sorry I was not able to get to this yesterday.  

Bartosz, thanks for working on this.  This should make many people's life a little easier.  Works very well.