Bug 172793 - EE combo box should show EE-JRE bindings
Summary: EE combo box should show EE-JRE bindings
Status: VERIFIED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M5   Edit
Assignee: Curtis Windatt CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on: 213628
Blocks:
  Show dependency tree
 
Reported: 2007-02-04 13:57 EST by Wassim Melhem CLA
Modified: 2008-02-05 14:22 EST (History)
2 users (show)

See Also:

Attachments
org.eclipse.pde.ui.patch (3.86 KB, patch)
2008-01-02 17:54 EST, Chris Aniszczyk CLA 		no flags Details | Diff
mylyn/context/zip (945 bytes, application/octet-stream)
2008-01-02 17:55 EST, Chris Aniszczyk CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Wassim Melhem CLA 2007-02-04 13:57:48 EST 
The EE combo box in the JRE section of the product editor should show in parenthesis the name of the JRE that is bound with each EE, or "unbound" if none exists.

This would indicate clearly to the user the JRE that will be copied

It would also be consistent with the behaviour of the combo on the JRE tab of the Java app launch configs.

Note that the jre name in the EE combo is just for display only.  It must not be persisted since it will have a different value from workspace to workspace.
Comment 1 Curtis Windatt CLA 2007-12-20 14:44:22 EST 
I am close to a fix on this one but am having some trouble with the ComboPart (which is using a CCombo).  #getSelectionIndex() is always returning -1.
Comment 2 Wassim Melhem CLA 2007-12-27 03:58:08 EST 
Curtis, what platform are you on?
Comment 3 Curtis Windatt CLA 2008-01-02 10:09:22 EST 
WinXP Sun 1.5
Comment 4 Wassim Melhem CLA 2008-01-02 10:11:23 EST 
If it's WinXP, it is very surprising that CCombo is being used at all.

Are you using one of those classic themes or something like that?
Comment 5 Curtis Windatt CLA 2008-01-02 10:18:36 EST 
Yes, I use the classic theme.  Never went for the XP look.  The selection works properly if I use a Combo instead of the ComboPart.
Comment 6 Chris Aniszczyk CLA 2008-01-02 17:53:59 EST 
The fix is to use SelectionListeners instead of modify, doh.
Comment 7 Chris Aniszczyk CLA 2008-01-02 17:54:59 EST 
Created attachment 86036 [details]
org.eclipse.pde.ui.patch

Use SelectionListener instead of ModifyListener
Comment 8 Chris Aniszczyk CLA 2008-01-02 17:55:01 EST 
Created attachment 86037 [details]
mylyn/context/zip
Comment 9 Chris Aniszczyk CLA 2008-01-02 17:55:19 EST 
done!
Comment 10 Brian Bauman CLA 2008-02-05 14:22:23 EST 
verified on I20080204-0800