Community
Participate
Working Groups
run,debug,export = sexy
+1 for sexiness
+1 Gonna use images instead of hyperlinks for this one.
Under advisement from a higher source, I'm told that Brian would be better suited for this task due to his work synchronizing the product and manifest editor overview pages. Brian, if you need to punt this one back, no worries.
I am up for suggestions on how to do the run/debug/(profile?) icons actions. Should we default to our run/debug methods for simplicity, or open a dialog (if more than open option is found) for the user to select which option they want? I guess my vote would be for #2, but wanted to get other's opinions before I got too far and had to redo it.
along the lines of #2 If we have more than one, can we show the launch config "types" in a drop-down menu like in the toolbar. If there is only one, then we only show the icon.
This enhancement was supposed to be easy, but then you went all fancy on us with this extensibility thing :) If comment 5 is too hard, then do the default. I think having a selection dialog would be too much.
Leave it to Wassim to solve complicated problems with the snap of his fingers :)
Created attachment 75858 [details] fix for this and bug 172531 This patch implements the sexiness as suggested in comment 5. For the purpose of code reuse, a fix for bug 172531 is included as well.
Looking really promising. Just a few things we need to fix up.
Created attachment 75888 [details] improved patch for both bugs Cleaned up some of my mess. Eliminated static methods. Fixed a problem with the build editor (in which it didn't work at all). Added export button sexiness to feature editor and build editor. But most importantly, added an overwritable method, PDEFormEditor#contributeToToolbar(IToolBarManager) that allows any PDEFormEditor to add whatever wants to all of its PDEFormPage's toolbars without the pages having to do anything. By default the method does nothing.
I like this patch ALOT. Very creative and an excellent solution! Originally we were going to open an enhancement request for slightly better memory management, but with the structure of the code this should be relatively simple. With that little bit of last improvement, I think this will be awesome!
Created attachment 76128 [details] optimized patch This patch is ashamed of its vastly inferior predecessor. Removed PDELauncherFormPage and added PDELauncherFormEditor. Pages now know nothing of their header buttons. All toolbar contributions are left up to the editor. All created actions are also cached in the editor so they are only created once and then provided to each page as they are opened.
ok, looks much better :) Can you modify AbstractTargetEditor to work with this new uber cool stuff? Also, can you modify the Update Site editor to include this functionality too (or you can open a separate bug for that). Once you have a new patch, I will review and commit it. Thanks Adam!
Created attachment 76147 [details] patch with additional editor support Added a build all button to the site editor. Icon for this to follow as another attachment. Refactored the cheat sheet editors so that the register link in the form header is provided by the editor (adding Mike as a reviewer for this). Refactored the target editor so the set as target platform link in the form header is provided by the editor.
Created attachment 76151 [details] icon for build all button icon is to be placed in "org.eclipse.pde.ui/icons/etool16"
*** Bug 172531 has been marked as a duplicate of this bug. ***
looks great Adam. You missed a copyright on CSAbstractEditor that I added. Looks sexy indeed!
Created attachment 76156 [details] mylyn/context/zip
