Bug 172348 - Dialog to add exception breakpoint extremely slow
Summary: Dialog to add exception breakpoint extremely slow
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 major (vote)
Target Milestone: 3.3 M5   Edit
Assignee: Michael Rennie CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2007-01-31 13:21 EST by Dani Megert CLA
Modified: 2007-02-01 13:19 EST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2007-01-31 13:21:51 EST 
I20070130-0800

Adding a Java exception breakpoint takes much longer that it used to. I guess this is caused by switching to the new FilteredItemsSelectionDialog.
Comment 1 Markus Keller CLA 2007-02-01 04:46:00 EST 
Could you please look at this for M5?

One problem is probably the one mentioned in bug 170603 comment 4: The dialog now builds a supertype hierarchy for every matched type, which does not scale in normal development workspaces.

Another problem could be that the AddExceptionDialog filters twice (it does not disable the items filter during search like the workaround we fixed for Open Type in bug 170884).
Comment 2 Darin Wright CLA 2007-02-01 09:25:06 EST 
Mike - I think we have to revert to showing all types, and then validating when the user selects a type...
Comment 3 Michael Rennie CLA 2007-02-01 11:46:37 EST 
fixed in HEAD

reverted to the 'old way' of not checking if the added exceptions are actually exceptions until they are validated on selection.

see AddExceptionDialog
Comment 4 Michael Rennie CLA 2007-02-01 11:46:56 EST 
please verify Darin W
Comment 5 Darin Wright CLA 2007-02-01 12:27:10 EST 
Found a class cast exception when an exception was chosen (and the label provider was being disposed twice, which caused an NPE - when the dialog was opened and cancel was pressed).
Comment 6 Darin Wright CLA 2007-02-01 12:27:39 EST 
Please verify changes.
Comment 7 Michael Rennie CLA 2007-02-01 13:19:16 EST 
verified