172221 – [patch] Better support for opening external files in the Include Browser tree

Bug 172221 - [patch] Better support for opening external files in the Include Browser tree

Summary: [patch] Better support for opening external files in the Include Browser tree

Status:	RESOLVED FIXED

Alias:	None

Product:	CDT
Classification:	Tools
Component:	cdt-core (show other bugs)
Version:	4.0
Hardware:	PC Windows XP

Importance:	P3 normal (vote)
Target Milestone:	4.0
Assignee:	Markus Schorn
QA Contact:

URL:
Whiteboard:
Keywords:	contributed

Depends on:
Blocks:

Reported:	2007-01-30 14:59 EST by Ed Swartz
Modified:	2008-06-19 23:52 EDT (History)
CC List:	1 user (show)

See Also:

Attachments
1) Use EditorUtility to open editors (better external file handling) (2.72 KB, patch) 2007-01-30 14:59 EST, Ed Swartz	bjorn.freeman-benson: iplog+	Details \| Diff
2) Use ICElement adapter and OpenCElementAction to open external files (3.17 KB, patch) 2007-01-30 15:00 EST, Ed Swartz	bjorn.freeman-benson: iplog+	Details \| Diff
3) Modify OpenCElementAction to check for IAdaptable objects (1.61 KB, patch) 2007-01-30 15:07 EST, Ed Swartz	bjorn.freeman-benson: iplog+	Details \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ed Swartz

2007-01-30 14:59:14 EST

Build ID: 20070129

Steps To Reproduce:
1. Make a project with external include files
2. Browse includes for a file referencing external #includes
3. If the external #includes of an include cannot be opened via Context > Open (the action is disabled), FAIL




More information:
This is a set of patches addressing the issues above.  

They allow external files to be navigated by taking advantage of the ability to map them to ICElement.

Comment 1 Ed Swartz

2007-01-30 14:59:47 EST

Created attachment 57838 [details]
1) Use EditorUtility to open editors (better external file handling)

Comment 2 Ed Swartz

2007-01-30 15:00:40 EST

Created attachment 57840 [details]
2) Use ICElement adapter and OpenCElementAction to open external files

Comment 3 Ed Swartz

2007-01-30 15:07:47 EST

Created attachment 57843 [details]
3) Modify OpenCElementAction to check for IAdaptable objects

Comment 4 Markus Schorn

2007-01-31 03:16:39 EST

I have a look.

Comment 5 Markus Schorn

2007-01-31 03:57:57 EST

Thanks, I have applied your patches with the exception of the change to IBNode.java, which is not necessary as IBFile attempts the conversion to a translation unit right away. If I am wrong, please reopen the bug.

Comment 6 Ed Swartz

2007-01-31 09:51:12 EST

Okay, I agree.  Thanks!

Comment 7 Doug Schaefer

2007-05-13 20:34:47 EDT

Setting to milestone 4.0 so we can generate a report of all bugs fixed in 4.0.

Comment 8 Doug Schaefer

2008-06-03 14:39:17 EDT

assigning

Comment 9 Doug Schaefer

2008-06-03 14:39:38 EDT

done