Bug 171767 - Main tab of PDE launch configurations is cut with bigger dialog font
Summary: Main tab of PDE launch configurations is cut with bigger dialog font
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.4 M6   Edit
Assignee: Benjamin Cabé CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday, contributed
: 185364 (view as bug list)
Depends on:
Blocks:
 
Reported: 2007-01-26 04:55 EST by Markus Keller CLA
Modified: 2008-02-11 15:31 EST (History)
3 users (show)

See Also:

Attachments
Screenshot (73.04 KB, image/png)
2007-01-26 04:55 EST, Markus Keller CLA 		no flags Details
Screenshot for 3.4M5 (64.77 KB, image/png)
2008-02-09 12:47 EST, Benjamin Cabé CLA 		no flags Details
Proposed patch (1.47 KB, patch)
2008-02-11 14:49 EST, Benjamin Cabé CLA 		no flags Details | Diff
mylyn/context/zip (764 bytes, application/octet-stream)
2008-02-11 14:49 EST, Benjamin Cabé CLA 		no flags Details
Screenshot when patch applied (62.51 KB, image/png)
2008-02-11 14:54 EST, Benjamin Cabé CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2007-01-26 04:55:10 EST 
I20070123-1715

Main tab of PDE launch configurations is cut if a bigger dialog font is used.
Comment 1 Markus Keller CLA 2007-01-26 04:55:40 EST 
Created attachment 57576 [details]
Screenshot
Comment 2 Brian Bauman CLA 2007-01-26 09:33:45 EST 
I had added some code to allow scrolling on the MainTab, so I can go back and see if it was something I did.
Comment 3 Wassim Melhem CLA 2007-05-09 23:55:09 EDT 
*** Bug 185364 has been marked as a duplicate of this bug. ***
Comment 4 Markus Keller CLA 2007-05-10 07:12:15 EDT 
If you don't fix it, I'll file another bug in 4 months (when I've again forgotten that I've already filed it... ;-)
Comment 5 Brian Bauman CLA 2008-02-06 00:04:05 EST 
Haven't had time to look at this.  Reassigning back to the inbox for others to have a crack at.
Comment 6 Benjamin Cabé CLA 2008-02-09 12:47:21 EST 
Created attachment 89343 [details]
Screenshot for 3.4M5

You did fixed it, Brian :)
Comment 7 Chris Aniszczyk CLA 2008-02-10 19:01:36 EST 
yay brian ;d
Comment 8 Markus Keller CLA 2008-02-11 05:33:32 EST 
Sorry, this is not fixed in 3.4M5.

Benjamin, did you also change the OS font when you took your screenshot? My OS font is the default (Tahoma 8) and the Eclipse dialog font is Tahoma 12.
Comment 9 Benjamin Cabé CLA 2008-02-11 05:50:40 EST 
Damn, you're right.

Markus, in fact I *only* changed OS font. The problem you describe occurs when the Eclipse dialog font is changed, and doesn't seem to occur when the OS font is changed.
I'll try to have a look at this bug.
Comment 10 Brian Bauman CLA 2008-02-11 10:17:08 EST 
If I remember right, there was an issue with a Group or Composite not computing it size correctly, but it has been a while since I have taken a look at this.
Comment 11 Benjamin Cabé CLA 2008-02-11 14:49:51 EST 
Created attachment 89442 [details]
Proposed patch

Here it is!
Comment 12 Benjamin Cabé CLA 2008-02-11 14:49:54 EST 
Created attachment 89443 [details]
mylyn/context/zip
Comment 13 Benjamin Cabé CLA 2008-02-11 14:54:28 EST 
Created attachment 89444 [details]
Screenshot when patch applied

... and with Eclipse dialog font setting set to Tahoma/14pt
Comment 14 Chris Aniszczyk CLA 2008-02-11 15:29:50 EST 
Oh, ok, looks like the culprit was appying the dialog font after computing the size? Weird :o!
Comment 15 Chris Aniszczyk CLA 2008-02-11 15:30:32 EST 
Thanks Ben! Hopefully this should keep Markus at bay :)
Comment 16 Benjamin Cabé CLA 2008-02-11 15:31:45 EST 
;-)