Bug 171684 - Replace references to IMarker.GENERATED_BY with IMarker.SOURCE_ID
Summary: Replace references to IMarker.GENERATED_BY with IMarker.SOURCE_ID
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.3 M5   Edit
Assignee: Maxime Daniel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 171682
  Show dependency tree
 
Reported: 2007-01-25 10:41 EST by John Arthorne CLA
Modified: 2007-02-05 12:09 EST (History)
0 users

See Also:

Attachments
Fix (13.34 KB, patch)
2007-01-26 09:33 EST, Maxime Daniel CLA 		no flags Details | Diff
Fix (17.36 KB, patch)
2007-01-31 01:21 EST, Maxime Daniel CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2007-01-25 10:41:12 EST 
Build: I20070110-1600

We introduced a new IMarker.GENERATED_BY attribute in 3.3. After discussion with the originator, this name doesn't properly capture the intended meaning of the attribute.  This attribute will be renamed to IMarker.SOURCE_ID to better reflect its meaning.  I have added the new SOURCE_ID attribute, and deprecated the GENERATED_BY attribute.  I would like to remove the GENERATED_BY attribute before the 3.3 M5 build. See bug 103847 for discussion.

There are five references to the GENERATED_BY attribute in the JavaBuilder class that need fixing up.
Comment 1 Maxime Daniel CLA 2007-01-26 09:33:29 EST 
Created attachment 57594 [details]
Fix

This patch fixes the deprecation warnings and aligns our constant name (JavaBuilder#GENERATED_BY becomes JavaBuilder#SOURCE_ID). We would prefer not to release it before the next I-build comes out, so as not to compell the whole JDT team to check org.eclipse.core.resources out. I'll release it asap after the next good I-build.
Comment 2 Maxime Daniel CLA 2007-01-26 09:34:28 EST 
I have also noticed that you took care of checking the value we had chosen with the users. We'll keep 'JDT' then. Thx a lot.
Comment 3 John Arthorne CLA 2007-01-26 18:08:01 EST 
No problem, I'll wait until after the next I-build to remove the old field.
Comment 4 Maxime Daniel CLA 2007-01-31 01:21:38 EST 
Created attachment 57889 [details]
Fix

Completes the former fix by a couple of renames in org.eclipse.jdt.core.tests.builder.Problem.
Comment 5 Maxime Daniel CLA 2007-01-31 02:10:57 EST 
Released for 3.3 M5.
Comment 6 David Audel CLA 2007-02-05 12:09:49 EST 
Verified for 3.3 M5 using warm-up build I20070205-0009