Bug 170920 - [api] Get rid of the org.eclipse.rse.logging plugin
Summary: [api] Get rid of the org.eclipse.rse.logging plugin
Status: CLOSED FIXED
Alias: None
Product: Target Management
Classification: Tools
Component: RSE (show other bugs)
Version: 1.0.1   Edit
Hardware: All All
: P3 enhancement (vote)
Target Milestone: 2.0   Edit
Assignee: Martin Oberhuber CLA
QA Contact: Martin Oberhuber CLA
URL:
Whiteboard:
Keywords: api
Depends on:
Blocks: 142475 170923
  Show dependency tree
 
Reported: 2007-01-18 10:18 EST by Martin Oberhuber CLA
Modified: 2008-08-13 13:17 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Oberhuber CLA 2007-01-18 10:18:50 EST 
Performance Logging should be removed from RSE since it was never used.
Remaining logging facilities should be moved into rse.core.
Comment 1 David Dykstal CLA 2007-03-28 23:08:34 EDT 
[api][refactor][170920]
Upon closer inspection it probably doesn't make sense to get rid of the plugin at this point in time since it consists of a combined "core" and "ui". A better refactoring is necessary and that has been accomplished. The packages should be able to be moved to other plugins later.

Removed PerformanceLogger per previous discussions
Renamed RemoteSystemLogListener to LogListener and made internal
Removed IRemoteSystemsLogging constants interface - moved constants to Logger, they were only referenced from the Logger anyway
Removed LabelUtil from its internal package - used hardcoded & for mnemonics instead
Removed usage of LabelUtil from LoggingPreferencePage
Removed all the resource bundle code from RemoteSystemsLoggingPlugin - it was obsolete

Migration considerations:
There should have been very little use of logging in using plugins and those should have been using LoggerFactory and Logger classes. These have not changed. SystemBasePlugin uses a Logger and provides access to these classes indirectly.
Comment 2 David Dykstal CLA 2007-03-28 23:10:27 EDT 
Work complete.
Comment 3 David Dykstal CLA 2007-03-29 10:25:57 EDT 
Reopening to continue discussion. This may be able to be split quite easily with the two non-ui packages going into core and the ui package going to the ui plugin.
Comment 4 Martin Oberhuber CLA 2007-03-30 10:38:33 EDT 
I actually think we have to split up the plugin into separate ui/core components.

Right now, rse.core depends on rse.logging which depends on eclipse.ui

If we ever want rse.core to be usable headless, we need to get rid at least of the UI components of logging. Since we don't see any usage for logging outside RSE, it's better to get rid of the plugin completely.
Comment 5 David Dykstal CLA 2007-03-30 10:51:12 EDT 
Excellent point. I'll do it today.
Comment 6 David Dykstal CLA 2007-03-30 17:32:17 EDT 
Moved org.eclipse.rse.logging and org.eclipse.rse.internal.logging to the core plugin. Adjusted the preference initializers in plugin.xml. Exported the packages.

Moved org.eclipse.rse.internal.logging.ui to org.eclipse.rse.internal.ui.logging. Moved help context items to the new plugin as well.

Neither of these is an API change.
Comment 7 David Dykstal CLA 2007-03-30 17:33:06 EDT 
Martin --

You'll want to remove the logging plugin from the build and the project sets.

-- Dave
Comment 8 Martin Oberhuber CLA 2007-04-02 06:40:13 EDT 
Removed all traces of org.eclipse.rse.logging

First build without the plugin is at
http://download.eclipse.org/dsdp/tm/downloads/drops/I20070402-0600
Comment 9 Martin Oberhuber CLA 2007-04-05 06:32:36 EDT 
Verified with I20070405-0600. Closing.
Comment 10 Martin Oberhuber CLA 2008-08-13 13:17:45 EDT 
[target cleanup] 2.0 M6 was the original target milestone for this bug