Bug 170637 - [javadoc] incorrect warning about missing parameter javadoc when using many links
Summary: [javadoc] incorrect warning about missing parameter javadoc when using many l...
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2.1   Edit
Hardware: PC Linux
: P3 minor with 1 vote (vote)
Target Milestone: 3.5 M2   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-16 10:47 EST by Kevin Goeser CLA
Modified: 2008-10-30 18:41 EDT (History)
3 users (show)

See Also:

Attachments
sample java code (1.98 KB, text/plain)
2007-01-16 10:49 EST, Kevin Goeser CLA 		no flags Details
[patch] - proposed fix + test case (top v_866) (7.88 KB, patch)
2008-05-21 04:22 EDT, Eric Jodet CLA 		no flags Details | Diff
Updated patch on top of v_912 (195.20 KB, patch)
2008-09-11 11:12 EDT, Frederic Fusier CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kevin Goeser CLA 2007-01-16 10:47:51 EST 
Build ID: M20060921-0945

Steps To Reproduce:
1. Set the compile up to warn about missing @param / @return javadoc tags.
2. Create a function with many parameters.
3. Add @param tags for all parameters
4. Paste {@link SomeClass} to all parameter docs
... at some number of used @links, Eclipse / Java warns about missing @param tags.

- Tested on Linux and Windows.
- Might be a problem of Java, too (?)
- Sun JDK 1.5.0.08
- Eclipse 3.2.1
Comment 1 Kevin Goeser CLA 2007-01-16 10:49:21 EST 
Created attachment 56963 [details]
sample java code

Sample code which creates incorrect warnings (first method).
Comment 2 Eric Jodet CLA 2008-05-21 04:22:59 EDT 
Created attachment 101198 [details]
[patch] - proposed fix + test case (top v_866)

passes all jdt.core, ui and text tests

(thanks to the large number of param tags) The problem was due to an ArrayIndexOutOfBoundsException in the AbstractCommentParser which prevented the parser to proceed.

Problem fixed by resizing the array when needed.
Comment 3 Jerome Lanneluc CLA 2008-05-21 04:57:20 EDT 
Since this is not a regression comparing to 3.3.2, will target 3.5
Comment 4 Frederic Fusier CLA 2008-09-11 11:12:15 EDT 
Created attachment 112313 [details]
Updated patch on top of v_912

The initial fix was good but the tests didn't fail when removing it => fix them + add a test for the test case provided in comment 1...
Comment 5 Frederic Fusier CLA 2008-09-11 12:37:45 EDT 
Released for 3.5M2
Comment 6 David Audel CLA 2008-09-15 06:50:12 EDT 
Verified for 3.5M2 using I20080914-2000