Bug 170595 - [batch][compiler] BatchCompilerTest#test024 is no more significant
Summary: [batch][compiler] BatchCompilerTest#test024 is no more significant
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M6   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-16 04:31 EST by Maxime Daniel CLA
Modified: 2007-03-21 06:03 EDT (History)
0 users

See Also:

Attachments
Proposed fix (7.31 KB, patch)
2007-03-07 14:30 EST, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Maxime Daniel CLA 2007-01-16 04:31:15 EST 
v_684_R32x
Fup on bug 161476.
BatchCompilerTest#test024 now passes even if the option it is expected to test is removed from the test case. The intent of test024 is to show that using an empty string as -extdirs value suppresses the defaut extention directories from the classpath. As it has been rewritten for bug 161476, the test will merely succeeded (that is, the compilation will fail), even if no -extdirs option was given at all.
Comment 1 Olivier Thomann CLA 2007-03-07 14:29:35 EST 
Then we should make the test specific to Sun VM since it is based on the fact that a certain type is in a jar located in the ext dirs folder.
I'll propose a patch for it.
Comment 2 Olivier Thomann CLA 2007-03-07 14:30:44 EST 
Created attachment 60392 [details]
Proposed fix

The test is "disabled" on VMs not from Sun.
At least on a Sun VM, it is checking that -extdirs "" is disabling the default ext dir contents.
Comment 3 Olivier Thomann CLA 2007-03-12 11:51:23 EDT 
I'll release the patch.
Comment 4 Olivier Thomann CLA 2007-03-12 14:11:20 EDT 
Released for 3.3M6.
Comment 5 Maxime Daniel CLA 2007-03-21 06:03:32 EDT 
Verified for 3.3 M6 using v_744.
(The test is enabled and visits the check for SUN VMs. Other VMs do not visit the significant part of the test, but the compiler behavior is not expected to depend on the running VM for the tested feature.)