Bug 170254 - "Snap Back" action cannot be performed on resizable labels
Summary: "Snap Back" action cannot be performed on resizable labels
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0.2   Edit
Hardware: All All
: P3 normal
Target Milestone: 1.0.3   Edit
Assignee: Alex Boyko CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-11 16:13 EST by Alex Boyko CLA
Modified: 2007-01-31 10:23 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Boyko CLA 2007-01-11 16:13:48 EST 
The "Snap Back" action as any DiagramAction extracts selected edit parts with the help of getTragetEditPart(Request) method. The LabelSnapBackEditPolicy understands the action's request but has no support for extracting target edit part for this request (the default method from GEF's GraphicalNodeEditPolicy is used instead). Hence, currently, target edit part for the "snap back" request is extracted by NonResizableLabelEditPolicy only. Therefore, resizable labels that don't have NonResizableLabelEditPolicy installed on them always have "Snap Back" action disabled, which is wrong.

The fix should be: override #getTargetEditPart(Request) on LabelSnapBackEditPolicy, since this is the only edit policy that creates the actual command for this request. All support for the "snap back" request should be deprecated on NonResizableLabelEditPolicy, since it has no business there.
Comment 1 Alex Boyko CLA 2007-01-12 11:21:28 EST 
Committed fixes for 1.0.3 and 2.0. The 2.0 fix has support for "snap back" request removed from NonResizableLabelEditPolicy. Marking as fixed.
Comment 2 Eclipse Webmaster CLA 2010-07-19 12:30:27 EDT 
[GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug