Bug 169846 - Facet bridge called 1034 times when opening dialog
Summary: Facet bridge called 1034 times when opening dialog
Status: NEW
Alias: None
Product: WTP Common Tools
Classification: WebTools
Component: Faceted Project Framework (show other bugs)
Version: unspecified   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: Project Inbox CLA
QA Contact: Konstantin Komissarchik CLA
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2007-01-08 11:06 EST by Tim deBoer CLA
Modified: 2013-12-16 02:28 EST (History)
4 users (show)

See Also:


Attachments
Patch caches runtime component information (1.62 KB, patch)
2007-02-27 15:56 EST, David Gorton CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim deBoer CLA 2007-01-08 11:06:42 EST
A WTP adopter noticed some extreme computation in the Add/Remove facets dialog and prompted me to take a look. In a smallish WTP workspace I opened the dialog and found that the RuntimeBridge is being called a whopping 1034 times.

The current runtime bridge appears to be incredibly fast (maybe ~80ms first call, 1/8ms every other time) but this still accounts for about 1/4 to 1/2 of the time taken to open the dialog. Even a minor degradation in the bridge or in adopter extensions (or if the # of calls are relative to # of runtimes or facets) would cause a performance problem opening the dialog.
Comment 1 Konstantin Komissarchik CLA 2007-02-08 16:45:49 EST
David, could you investigate? We should address this for the 2.0 release.
Comment 2 David Gorton CLA 2007-02-27 15:56:51 EST
Created attachment 59918 [details]
Patch caches runtime component information
Comment 3 Konstantin Komissarchik CLA 2007-02-28 17:41:18 EST
It's not quite that easy, I am afraid. We cannot cache components in the BridgedRuntime because we have no way of knowing when the cached list gets stale. For instance if a user adjusts the runtime vm, that will change the runtime component (different component version). 

What we really need to do is analyze why that many calls are being made and to figure out a way (in the wizard) to reduce the number of calls. If the number of calls cannot be easily reduced, we can try caching in the context of the wizard, but I'd rather not do that.
Comment 4 John Lanuti CLA 2007-06-12 10:18:14 EDT
This sounds like it needs some more thought and is too risky given 2.0 shutdown.  Deferring.
Comment 5 Chuck Bridgham CLA 2007-09-11 09:48:16 EDT
Moving to 202.....
Comment 6 David Williams CLA 2008-06-19 00:58:35 EDT
This target (and/or status) does not seem correct. 
Is it fixed in 2.0.2? Or ... does it need to be targeted to 3.0.1? 



Comment 7 Roberto Sanchez Herrera CLA 2012-04-10 13:28:31 EDT
Pinging for this bug. Could we put this into plan for a release? This is still a problem for WTP adopters.
Comment 8 Konstantin Komissarchik CLA 2012-04-10 14:08:17 EDT
The best way to revive a bug that isn't going anywhere is to contribute analysis and a patch. See Comment #3. I will certainly take the time to review any proposed solution.