Bug 169480 - MANIFEST.MF editor does not display plug-in names with commas
Summary: MANIFEST.MF editor does not display plug-in names with commas
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.3 M5   Edit
Assignee: Brian Bauman CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2007-01-03 17:02 EST by Remy Suen CLA
Modified: 2007-01-11 13:32 EST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Remy Suen CLA 2007-01-03 17:02:23 EST 
I don't know if commas are supposed to be allowed in a plug-in's name (not the id), but they are not being properly displayed in the 'Overview' tab of the multi-page editor if you do use them.

If you put in 'a,b' and save, the text field is set to just 'a'. If you click on the 'MANIFEST.MF' tab, you do see 'a,b' as the name though. The same applies for 'a,b,c', resetting to 'a'. If you use 'a,,b', the text field is cleared to '', the empty string, so I guess some kind of comma parser is involved here.

Either way, I guess the parser needs to be updated to flag an error for using commas or changed to return the correct name with the comma(s).
Comment 1 Brian Bauman CLA 2007-01-11 13:32:06 EST 
Should be fixed in 3.3M5.  The problem was that we are using the ManifestElement parser when we should not be.  

For future reference, we use the parse function for the following headers:
Fragment-Host
Bundle-SymbolicName

We do NOT use the parse function for the following headers:
Eclipse-PatchFragment
Bundle-Activator
Eclipse-ExtensibleAPI
Bundle-Version
Bundle-Name