Community
Participate
Working Groups
Provide-Package is deprecated and should have a proper warning. It would also be nice to have a quickfix so it could be moved to the Export-Package header.
hey Chris, are you working on this one?
Created attachment 74290 [details] Patch to add validate Provide-Package and provide quick fix Hope it isn't too early to start on the bugday issues, but I have attached a patch that should do what you want. Adds a new check to mark the Provide-Package header as deprecated if the target version is >= 3.1 (I assume this is when it was deprecated). Also adds a quick fix for the problem that will rename the header to Export-Package.
It's not too early Brock, thanks :) Sorry for the slow reply on my part, I was away this weekend. I added you to the participants list here: http://wiki.eclipse.org/BugDayJuly2007#Participants I'll look over the patch tomorrow and if it's good, I'll release. Thanks!
Brian to review patch.
Created attachment 74705 [details] minor modification to Brock's patch Brock, thanks for the patch! It looked really good. I went ahead and made two minor changes (along with copyright updates). I am posting an updated patch for Chris to review. 1. Use isCheckDeprecated() function with a slightly different report(...) function call. Your way worked fine, I just changed it to be more consistent with the way we check/report other deprecated checks. 2. Instead of validating TargetVersion >= 3.1, I used the fOSGiR4 variable. I opened bug 197984 to deal with an inconsistency in the way we do singleton validation. This validation is very similar so I just went ahead and updated it.
+1, I committed to HEAD. Thanks for the review Brian and thanks for the hard work Brock. Now you need to send a picture with a leafy background so we can include it on our contributors page :)
Created attachment 74720 [details] mylyn/context/zip
