Bug 168937 - Axis2: Support import of AAR
Summary: Axis2: Support import of AAR
Status: NEW
Alias: None
Product: WTP Webservices
Classification: WebTools
Component: jst.ws (show other bugs)
Version: 2.0   Edit
Hardware: PC Windows XP
: P2 enhancement (vote)
Target Milestone: Future   Edit
Assignee: Saminda Wijeratne CLA
QA Contact: Keith Chong CLA
URL:
Whiteboard: Axis2
Keywords: helpwanted
Depends on:
Blocks:
 
Reported: 2006-12-22 10:42 EST by Kathy Chan CLA
Modified: 2010-06-10 13:44 EDT (History)
2 users (show)

See Also:


Attachments
icon for patch for 168937 (1.17 KB, patch)
2009-03-05 06:00 EST, Saminda Wijeratne CLA
no flags Details | Diff
patch for 168937 (26.94 KB, patch)
2009-03-05 06:01 EST, Saminda Wijeratne CLA
no flags Details | Diff
Null Pointer (4.17 KB, text/plain)
2009-03-10 14:57 EDT, Keith Chong CLA
no flags Details
patch for 168937 (27.96 KB, patch)
2010-03-17 04:10 EDT, Saminda Wijeratne CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kathy Chan CLA 2006-12-22 10:42:04 EST
As part of Axis2 integration into WTP, we need to support the import of Axis service archive (AAR) into the workspace.  Once the AAR is imported, it should be represented in an exploded form in the workspace.

After the import, the Axis2 Web service validator would be triggered to validate the AAR (e.g. services.xml).

The user should be able to use a Browse button to browse for an AAR file or import from an exploded directory containing the AAR structure.

This is a subordinate RFE under bug 165664.
Comment 1 Chris Brealey CLA 2007-01-30 09:23:15 EST
Not contained in M5. Deferred to M6.
Comment 2 Kathy Chan CLA 2007-03-14 11:06:37 EDT
Could not make it into WTP 2.0 M6.  Deferred out of WTP 2.0.
Comment 3 Kathy Chan CLA 2007-07-24 17:29:08 EDT
Targetting WTP 3.0.
Comment 4 Kathy Chan CLA 2008-04-10 14:26:28 EDT
Setting target field to future since all WTP 3.0 RFEs needs to be in by M6 which had already been declared.  Please put a more accurate target when these RFEs are in plan for a particular release.
Comment 5 Saminda Wijeratne CLA 2009-03-05 06:00:14 EST
Created attachment 127637 [details]
icon for patch for 168937

This icon is created in WSO2 for the purpose of representing axis2 archives. I
got the OK for using this icon in eclipse from Samisa. Therefore we are
herewith giving permission to use this icon to eclipse wtp axis2 project under
the eclipse license.

Just extract the icons.zip file to the
org.eclipse.jst.ws.axis2.consumption.ui project folder.
Comment 6 Saminda Wijeratne CLA 2009-03-05 06:01:33 EST
Created attachment 127638 [details]
patch for 168937

This patch contains the updated code for the importing functionality including the
code for specifying the icon.
Comment 7 Keith Chong CLA 2009-03-10 14:57:49 EDT
Created attachment 128248 [details]
Null Pointer

If you do an import without first selecting a project, you will get the null pointer.
Comment 8 Keith Chong CLA 2009-03-10 15:11:48 EDT
Hi Saminda, I think the Axis2 Service Archive Importer wizard page could have better fit and finish.  ie. when you resize the dialog width-wise, you'll notice the spacing between the labels and the text field.  The left part of the text fields should still remain fixed against the right side of the label.

Also, note that if you press Back, it goes to an empty page. It should go back to the regular Import page.

Please externalize the strings.
Comment 9 Keith Chong CLA 2009-03-16 13:54:22 EDT
Hi Saminda,

Any outlook on updating your patch with fixes to address the issues I've found?  I think this and the sibling bug 168938 should be checked in at the same time.   M6 is going to be declared this week, so I think if we are going to get these fixes in, we should defer this* until M7 (earlier the better) and seek PMC approval for these changes.   What do you think?

*if possible, pull out all the strings into the properties file and we can check these string changes in for M6, tomorrow (Tuesday).  At least we will have the strings available in M7.
Comment 10 Keith Chong CLA 2009-03-17 15:53:20 EDT
Deferring to 3.1 M7.
Comment 11 Saminda Wijeratne CLA 2009-03-24 09:57:46 EDT
Hi Keith,

I've being trying to figure out why a blank page appears when back button is pressed. But I couldn't find the reason. I couldn't find a decent example of an import/export wizard to compare my work with to check where I'm going wrong. Being struggling with this for a couple of days now. Any ideas??

Thanx,
Saminda 
Comment 12 Keith Chong CLA 2009-04-30 12:51:39 EDT
Hi Saminda, let's revisit this enhancement for 3.2.
Comment 13 Keith Chong CLA 2010-03-04 14:00:22 EST
(In reply to comment #11)
> Hi Keith,
> I've being trying to figure out why a blank page appears when back button is
> pressed. But I couldn't find the reason. I couldn't find a decent example of an
> import/export wizard to compare my work with to check where I'm going wrong.
> Being struggling with this for a couple of days now. Any ideas??
> Thanx,
> Saminda

Saminda, sorry, I don't have the time to look at this.  I will move designate this and its companion bug (export AAR) as helpwanted.   Please modify if necessary.
Comment 14 Saminda Wijeratne CLA 2010-03-17 04:10:18 EDT
Created attachment 162242 [details]
patch for 168937

Fixed the NPE and the problem of showing a blank page when back is clicked. The reason was that I had set the parent composite as the control instead of the container in the wizard page createControl method. This patch shares code with bug 168938.

Please verify and commit.

Saminda