Comment 1 Fernando Calheiros 2007-05-15 13:40:21 EDT

Created attachment 67287 [details]
Makes InterTypeFieldDeclaration have the target type, updates the matcher and the converter accordingly

InterTypeFieldDeclaration now has only one variable declaration fragment and the target type (onType).

Made InterTypeFieldDeclaration extend BodyDeclaration instead of FieldDeclaration, copied everything that was needed from FieldDeclaration.

Updated the converter to add the target type to the ITFD and the matcher to check the target type also.

This is my first patch, don't hesitate to tell me if I did something wrong. :)

Comment 2 Fernando Calheiros 2007-05-15 13:54:24 EDT

Oops, just noticed that ON_TYPE_PROPERTY in InterTypeFieldDeclaration was set to Type.class when it's actually Name.class.

Comment 3 Andrew Clement 2008-01-22 14:21:30 EST

hmmm.  I integrated an enhancement from someone else earlier today that added ontype to itd methods and fields.  However, they did it in quite a simplistic way.  I see here that a more thorough and correct change is proposed for InterTypeFieldDeclarations - however after applying it to the current codebase, some of the AspectJ tests that check the Ast code are failing.  I don't know if you had a chance to run all the tests or not but I can't commit it until they are passing.  I am not sure if you are still interested in getting this addressed, but if you are then I will commit the change (once the tests are passing) now the dust has settled on 1.6.0

Comment 4 Andrew Clement 2008-10-02 13:56:32 EDT

patch needs a bit of rework before inclusion.