Bug 168669 - The Load target button in the PDE preferences page for Target Platform is not enabled correctly
Summary: The Load target button in the PDE preferences page for Target Platform is not...
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.3 M5   Edit
Assignee: Brian Bauman CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on: 170215
Blocks:
  Show dependency tree
 
Reported: 2006-12-20 07:53 EST by Félix Cuadrado CLA
Modified: 2007-06-05 18:36 EDT (History)
2 users (show)

See Also:

Attachments
Patch for TargetPlatformPreferencesPage fixing the error (1.31 KB, patch)
2006-12-20 07:55 EST, Félix Cuadrado CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Félix Cuadrado CLA 2006-12-20 07:53:58 EST 
Build ID: 3.3M4

Steps To Reproduce:
1. Install clean 3.3M4 in Linux (In my case the distro was Kubuntu)
2. Go to Help / Preferences / Target Platform
3. When you select any of the already defined targets, the load target button is not enabled.


More information:
While reproducing the same steps on Windows the page works correctly. It seems the Combo ModifyEvents are handled differently in both versions.
Adding a SelectionListener to the TargetPlatformPreferencesPage gets it to work in Linux too.
Comment 1 Félix Cuadrado CLA 2006-12-20 07:55:21 EST 
Created attachment 55960 [details]
Patch for TargetPlatformPreferencesPage fixing the error
Comment 2 Wassim Melhem CLA 2007-01-11 05:45:15 EST 
Grant, is this a bug in SWT?  ie. a bug in the handling of ModifyEvent on Linux.

or should we proceed with the patch that adds yet another listener on the combo box?
Comment 3 Grant Gayed CLA 2007-01-11 09:36:29 EST 
This is an swt bug, so I've logged bug 170215.  However you may wish to apply the attached patch in the meantime, as I'm not sure when this bug will be addressed, and setting the enabled state on the Load Profile button twice should not be a problem.
Comment 4 Brian Bauman CLA 2007-01-11 10:24:45 EST 
I can take this bug.  I looked into this quickly when it was first opened.  I believe we can remove the selection listener completely if we use a modify listener.  If so, I would rather have one listener instead of two.
Comment 5 Wassim Melhem CLA 2007-01-11 10:27:34 EST 
brian, we already have a modify listener.  the patch adds a selection listener.
Comment 6 Brian Bauman CLA 2007-01-11 10:31:53 EST 
ok, then reverse what I said :)  I get confused first thing in the morning
Comment 7 Brian Bauman CLA 2007-01-11 16:14:07 EST 
Felix, thank you very much for the patch!  I released a slightly modified version (removed the ModifyListener and extended SelectionAdapter instead of implementing ISelectionListener).

Should be available in 3.3M5.