Bug 168546 - [Editors] Highlight externalized strings within XML editors
Summary: [Editors] Highlight externalized strings within XML editors
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.4 M2   Edit
Assignee: Mike Pawlowski CLA
QA Contact:
URL:
Whiteboard:
Keywords: noteworthy
Depends on:
Blocks:
 
Reported: 2006-12-19 09:51 EST by Simon Archer CLA
Modified: 2007-09-14 16:08 EDT (History)
3 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Archer CLA 2006-12-19 09:51:14 EST 
It would be helpful if a highlight color preference was provided for externalized strings, such as "%name".  Today there is only one preference for all strings ("Constant strings"), which makes it tricky to spot values that you intend to externalize.

Not only would this feature help the reader find externalized string, but it would probably be helpful in spotting places where you forgot to prefix the string with a percent sign.

I would like to suggest that the default color not be some shade of green, but rather something distinct, such as magenta.  ;-)
Comment 1 Brian Bauman CLA 2006-12-19 17:10:13 EST 
Mike, when you get a chance can you take a look at this?  I figured you are the goto guy for XML work :)
Comment 2 Mike Pawlowski CLA 2007-09-14 13:37:06 EDT 
Fixed.  Patch released to HEAD.

Target:  3.4 M2

Work Done:

* Highlight externalized strings within the following contexts:
  -> XML attribute values
  -> XML element text content

* Added new "Externalized strings" preference to control highlight color
  -> Default color is a neutral purple (HTML/CSS color) - sorry Simon,
     magenta hurts my eyes ;))

Noteworthy !
Comment 3 Simon Archer CLA 2007-09-14 16:08:33 EDT 
Sounds ideal, thanks.  Noteworthy indeed.