Community
Participate
Working Groups
Sorry if this isn't really a bug, but since we are supposed to use clip regions to use gradient fills, it seems like one. Problem: If you want to fill something using a gradient fill you must first clip the region and then fill the bounding box will fillGradient. However, since clipping does not obey the fill rules, there are some figures you cannot properly fill. Clipping always seems to use the EvenOdd rule, but if a path crosses back on itself this will leave holes in clip. It would be great if the clip regions on the GC obeyed the fill rules setting. I will attach a screen-shot to show you what I mean.
Created attachment 55416 [details] Screenshot of the problem Here is a screenshot that shows the problem. Note: I have only tried this on GTK+.
Please could you provide your testcase? Thanks!
Opps.. :) It works great in SWT. The power of a snippet! It is actually the graphics class in Draw2D. I assumed that the rules were just passed through to SWT. It seems that draw2D only sets the fill rules before the fill method is called, so if you set the fill rule and do a clip, the rule is not updated. I am reassigning this to Draw2D and I will attach a Draw2D snippet in a second.
Created attachment 56925 [details] Snippet showing the problem This snippet shows how SWTGraphics does not update the fill rule until after a fill method is called. It should also be updated when setClip is called since clipping obeys fill rules.
This can actually be fixed by calling checkGC() when setClip is called. This should be safe to call here right? Do you want me to create a patch? Cheers, ian
I've delivered a change that is less expensive than calling checkGC(), and probably safe enough to be considered for 3.4.1. Anthony/Lidija/Ian, check if the change works for you and figure out whether you want to backport to 3.4.1. If there's no need to backport, we can probably resolve as fixed. WORKAROUND for pre-3.5: Ian, another way to achieve the same results without encountering the bug in existing releases is to call: Path path = ...; Pattern pattern = new Pattern([[color 1, color 2, top of path, bottom of path]]); graphics.setBackgroundPattern(pattern); pattern.dispose(); graphics.fillPath(path); In fact, this is better in several ways because you have the option of enabling anti-aliasing, and/or outlining the path (drawPath(path));
(In reply to comment #6) Seems to be working fine.
Fixed, see comment #6
