Bug 167317 - ecjsrc.zip should contain a build system
Summary: ecjsrc.zip should contain a build system
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2.1   Edit
Hardware: PC Linux
: P3 normal (vote)
Target Milestone: 3.3 M6   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL: http://download.eclipse.org/eclipse/d...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-12-09 06:58 EST by Petteri Räty CLA
Modified: 2007-03-21 05:50 EDT (History)
0 users

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Petteri Räty CLA 2006-12-09 06:58:00 EST
Steps To Reproduce:
1.download http://download.eclipse.org/eclipse/downloads/drops/R-3.2.1-200609210945/download.php?dropFile=ecjsrc.zip
2.try to build it
3.find that no build system is included


More information:
pena work # find | egrep -v "java$"
.
./org
./org/eclipse
./org/eclipse/jdt
./org/eclipse/jdt/core
./org/eclipse/jdt/core/compiler
./org/eclipse/jdt/core/compiler/package.html
./org/eclipse/jdt/internal
./org/eclipse/jdt/internal/antadapter
./org/eclipse/jdt/internal/antadapter/messages.properties
./org/eclipse/jdt/internal/compiler
./org/eclipse/jdt/internal/compiler/ast
./org/eclipse/jdt/internal/compiler/env
./org/eclipse/jdt/internal/compiler/flow
./org/eclipse/jdt/internal/compiler/impl
./org/eclipse/jdt/internal/compiler/util
./org/eclipse/jdt/internal/compiler/codegen
./org/eclipse/jdt/internal/compiler/batch
./org/eclipse/jdt/internal/compiler/batch/messages.properties
./org/eclipse/jdt/internal/compiler/messages.properties
./org/eclipse/jdt/internal/compiler/lookup
./org/eclipse/jdt/internal/compiler/parser
./org/eclipse/jdt/internal/compiler/parser/diagnose
./org/eclipse/jdt/internal/compiler/parser/part1.rsc
./org/eclipse/jdt/internal/compiler/parser/part2.rsc
./org/eclipse/jdt/internal/compiler/parser/parser1.rsc
./org/eclipse/jdt/internal/compiler/parser/parser2.rsc
./org/eclipse/jdt/internal/compiler/parser/parser3.rsc
./org/eclipse/jdt/internal/compiler/parser/parser4.rsc
./org/eclipse/jdt/internal/compiler/parser/parser5.rsc
./org/eclipse/jdt/internal/compiler/parser/parser6.rsc
./org/eclipse/jdt/internal/compiler/parser/parser7.rsc
./org/eclipse/jdt/internal/compiler/parser/parser8.rsc
./org/eclipse/jdt/internal/compiler/parser/parser9.rsc
./org/eclipse/jdt/internal/compiler/parser/start1.rsc
./org/eclipse/jdt/internal/compiler/parser/start2.rsc
./org/eclipse/jdt/internal/compiler/parser/part14.rsc
./org/eclipse/jdt/internal/compiler/parser/readableNames.properties
./org/eclipse/jdt/internal/compiler/parser/parser10.rsc
./org/eclipse/jdt/internal/compiler/parser/parser11.rsc
./org/eclipse/jdt/internal/compiler/parser/parser12.rsc
./org/eclipse/jdt/internal/compiler/parser/parser13.rsc
./org/eclipse/jdt/internal/compiler/parser/parser14.rsc
./org/eclipse/jdt/internal/compiler/parser/parser15.rsc
./org/eclipse/jdt/internal/compiler/parser/parser16.rsc
./org/eclipse/jdt/internal/compiler/parser/parser17.rsc
./org/eclipse/jdt/internal/compiler/parser/parser18.rsc
./org/eclipse/jdt/internal/compiler/parser/parser19.rsc
./org/eclipse/jdt/internal/compiler/parser/parser20.rsc
./org/eclipse/jdt/internal/compiler/parser/parser21.rsc
./org/eclipse/jdt/internal/compiler/parser/parser22.rsc
./org/eclipse/jdt/internal/compiler/parser/parser23.rsc
./org/eclipse/jdt/internal/compiler/parser/parser24.rsc
./org/eclipse/jdt/internal/compiler/classfmt
./org/eclipse/jdt/internal/compiler/problem
./org/eclipse/jdt/internal/compiler/problem/messages.properties
./about.html

Thanks for distributing a separate source zip. This would be more useful if you included a build system too so people wanting to build ecj from that source would not have to go looking for CVS. The primary use of the sources IMHO is to build it.

http://www.eclipse.org/proposals/linux-distro/
Comment 1 Olivier Thomann CLA 2006-12-09 14:21:55 EST
An ant script would be good enough?
Comment 2 Petteri Räty CLA 2006-12-09 16:12:43 EST
(In reply to comment #1)
> An ant script would be good enough?
> 

Everything that is needed to build an identical jar to http://download.eclipse.org/eclipse/downloads/drops/R-3.2.1-200609210945/download.php?dropFile=ecj.jar

Probably this just means the build.xml file.
Comment 3 Philipe Mulet CLA 2006-12-11 09:41:09 EST
The source.zip is intended to be attached to the binary.jar for browsing purpose. I am not sure the sources should be polluted with build files... at least, this would be a new requirement.

Shouldn't such a file rather be located elsewhere ? Could be linked from our development resources page... now I could see why bundling it would allow to evolve it along with the sources layout.
Comment 4 Petteri Räty CLA 2006-12-16 06:14:47 EST
(In reply to comment #3)
> The source.zip is intended to be attached to the binary.jar for browsing
> purpose. I am not sure the sources should be polluted with build files... at
> least, this would be a new requirement.
>

This is exactly the attitude that makes Eclipse so hard to package on Linux distributions and what the linux-distro project tries to solve. One build.xml file is hardly much pollution and for example on Gentoo our package manager automatically creates the src.zip stripped to just java files if you want to.

> 
> Shouldn't such a file rather be located elsewhere ? Could be linked from our
> development resources page... now I could see why bundling it would allow to
> evolve it along with the sources layout.
> 

Just makes things unnecessarily harder. Hopefully this does not come out as too harsh. If you want to have a separate stripped src.zip that is fine by me. It should not be hard to write ant targets to automatically create the files for you.

Thanks.
Comment 5 Olivier Thomann CLA 2007-02-15 13:27:44 EST
Released for 3.3M6.
I'll verify the next build to see if the script is properly included.
Comment 6 David Audel CLA 2007-03-21 05:50:33 EDT
Verified for 3.3 M6 using build I20070321-0010