Bug 167302 - Plugin's View Filter counter doesn't update upon target platform change
Summary: Plugin's View Filter counter doesn't update upon target platform change
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M5   Edit
Assignee: Sean Kennedy CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-12-08 17:44 EST by Brian Bauman CLA
Modified: 2007-06-05 18:35 EDT (History)
2 users (show)

See Also:


Attachments
Here is the fix. (2.14 KB, patch)
2007-01-24 08:51 EST, Sean Kennedy CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Bauman CLA 2006-12-08 17:44:23 EST
In the plug-ins view, there is a counter stating how many plug-ins the filter is currently matching.  This number does not get updated upon selecting a new target platform.

Should be an easy fix.  Need to listen for model changes in PluginsView instead of PluginsContentProvider.  When models change, then need to refresh the viewer through the PluginsContentProvider, but also update the counter (updateContentDescription).
Comment 1 Wassim Melhem CLA 2006-12-13 17:02:16 EST
Assigning to Sean.  Let's see what he is made of ;)
Comment 2 Brian Bauman CLA 2006-12-13 17:26:29 EST
hooray for more help!  

Sean, if you get stuck, let me know and I can try to help.
Comment 3 Chris Aniszczyk CLA 2006-12-14 11:28:31 EST
welcome Sean, if you need help, feel free to ping me on Sametime or better yet, use IRC and idle on #eclipse-dev

Wassim and Brian are posers, they don't idle there, so come idle with the 'cool' people

http://wiki.eclipse.org/index.php/IRC
Comment 4 Chris Aniszczyk CLA 2006-12-14 11:29:48 EST
oops
Comment 5 Chris Aniszczyk CLA 2006-12-28 00:03:11 EST
come on Sean, you can do it ;)
Comment 6 Wassim Melhem CLA 2007-01-23 15:41:26 EST
Last day to get this fix in is Feb 2, 2007.

wake up, Sean :)
Comment 7 Sean Kennedy CLA 2007-01-24 08:51:29 EST
Created attachment 57428 [details]
Here is the fix.

I must have taken to long to start work on this, there were some pretty big changes to PluginView and PluginContentProvider between when I first got the source and this patch ... of course the patch was really trivial now.
I didn't realize such (seemingly) big changes would be made ... I mean PluginContentProvider no longer implements IPluginModelListener and PluginView does.
Anyway, that looks like the right thing to do ... I just never would have done it since I'd have been afraid to break something else.
Comment 8 Wassim Melhem CLA 2007-01-24 11:54:57 EST
Thanks Sean.  I just applied the patch, which plays very well.  This patch is so much better than my good friend Chris' first patch :)

Your observations are all correct in comment 7 about the view and the listener.  That is why I made the view to be the listener over the weekend.