Bug 167136 - DiagramGenerator#findConnectionsToPaint() filters out connections to itself
Summary: DiagramGenerator#findConnectionsToPaint() filters out connections to itself
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 2.0   Edit
Hardware: All All
: P3 normal
Target Milestone: 1.0.3   Edit
Assignee: Alex Boyko CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-12-07 13:40 EST by Alex Boyko CLA
Modified: 2010-07-19 12:29 EDT (History)
1 user (show)

See Also:


Attachments
proposed patch (1.06 KB, patch)
2006-12-07 13:42 EST, Alex Boyko CLA
no flags Details | Diff
patch (1.44 KB, patch)
2006-12-11 17:31 EST, Alex Boyko CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Boyko CLA 2006-12-07 13:40:51 EST
Build ID: 3.2.1

Steps To Reproduce:
1. Create a Circuit on a Logic diagram.
2. Put ageoshape inside the circle
3. Create a "Line" connector from the geoshape to itself
4. Right-click on the circuit or its compartment File->Save as Image File... (any format)
Problem: look at the image the connection from the geoshape to itself is missing

When selected nodes are being copied to an image, connections from a node to itself will be missing from the image.
DiagramGenerator#findConnectionsToPaint() method spefically has a condition to filter connection from a node to itself out. GMF does support such connections, hence the condition above must be removed.



More information:
Comment 1 Alex Boyko CLA 2006-12-07 13:42:38 EST
Created attachment 55266 [details]
proposed patch

Removed the mentioned above condition. Tested with logic example and a client application.
Comment 2 Alex Boyko CLA 2006-12-11 17:31:56 EST
Created attachment 55444 [details]
patch

Corrected patch
Comment 3 Alex Boyko CLA 2006-12-18 10:41:00 EST
Fix has been committed. Marking as fixed
Comment 4 Eclipse Webmaster CLA 2010-07-19 12:29:03 EDT
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Diagram was the original product and component for this bug