Bug 166348 - [search] Stack trace console resolves wrong source
Summary: [search] Stack trace console resolves wrong source
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M4   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-30 09:11 EST by Darin Wright CLA
Modified: 2006-12-12 10:31 EST (History)
0 users

See Also:


Attachments
Proposed patch (3.42 KB, patch)
2006-12-06 13:18 EST, Frederic Fusier CLA
no flags Details | Diff
Jar file for tests (955 bytes, application/octet-stream)
2006-12-06 13:20 EST, Frederic Fusier CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Wright CLA 2006-11-30 09:11:15 EST
I20061128-0800

When I paste this trace into a Java stack trace console, the TreeViewer links take me to com.ibm.jvm.findroots.TreeViewer instead of the org.eclipse.jface.viewers.TreeViewer.


org.eclipse.core.runtime.AssertionFailedException: null argument:
    at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:84)
    at org.eclipse.core.runtime.Assert.isNotNull(Assert.java:72)
    at org.eclipse.jface.viewers.AbstractTreeViewer.getTreePathFromItem(AbstractTreeViewer.java:2667)
    at org.eclipse.jface.viewers.TreeViewer.virtualLazyUpdateWidget(TreeViewer.java:937)
    at org.eclipse.jface.viewers.TreeViewer.access$2(TreeViewer.java:933)
    at org.eclipse.jface.viewers.TreeViewer$2.handleEvent(TreeViewer.java:325)
    at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:66)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1095)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1119)
    at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1104)
    at org.eclipse.swt.widgets.Tree.checkData(Tree.java:317)
    at org.eclipse.swt.widgets.Tree.cellDataProc(Tree.java:252)
    at org.eclipse.swt.widgets.Display.cellDataProc(Display.java:663)
    at org.eclipse.swt.internal.gtk.OS._gtk_main_do_event(Native Method)
    at org.eclipse.swt.internal.gtk.OS.gtk_main_do_event(OS.java:5533)
    at org.eclipse.swt.widgets.Display.eventProc(Display.java:1154)
    at org.eclipse.swt.internal.gtk.OS._g_main_context_iteration(NativeMethod)
    at org.eclipse.swt.internal.gtk.OS.g_main_context_iteration(OS.java:1472)
    at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:2896)
    at org.eclipse.ui.internal.Workbench.runEventLoop(Workbench.java:1945)
    at org.eclipse.ui.internal.Workbench.runUI(Workbench.java:1909)
    at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:425)
    at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:149)
    at org.eclipse.ui.internal.ide.IDEApplication.run(IDEApplication.java:95)
    at org.eclipse.core.internal.runtime.PlatformActivator$1.run(PlatformActivator.java:78)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:104)
    at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:74)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:348)
    at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:165)
    at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
    at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:39)
    at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:25)
    at java.lang.reflect.Method.invoke(Method.java:585)
    at org.eclipse.core.launcher.Main.invokeFramework(Main.java:341)
    at org.eclipse.core.launcher.Main.basicRun(Main.java:285)
    at org.eclipse.core.launcher.Main.run(Main.java:987)
    at org.eclipse.core.launcher.Main.main(Main.java:962)
Comment 1 Darin Wright CLA 2006-12-05 11:27:18 EST
In this case a search is performed for 'org.eclipse.jface.viewers.TreeViewer' with the following settings:

SearchPattern.createPattern('org.eclipse.jface.viewers.TreeViewer', IJavaSearchConstants.TYPE, IJavaSearchConstants.DECLARATIONS, SearchPattern.R_EXACT_MATCH);

Even though we asked for an exact match, we get search result hits for 'com.ibm.jvm.findroots.TreeViewer', and ''com.ibm.jvm.ras.findroots.TreeViewer' as well. I would not expect this when askign for R_EXACT_MATCH.
Comment 2 Darin Wright CLA 2006-12-05 12:04:03 EST
Moving to JCORE - feels like a search bug.
Comment 3 Darin Wright CLA 2006-12-05 12:07:33 EST
Note that the 'com.ibm.*' classes are showing up in a j9 1.4.2 VM, which is on the classpath of a project in my workspace.
Comment 4 Frederic Fusier CLA 2006-12-06 13:18:12 EST
Created attachment 55150 [details]
Proposed patch
Comment 5 Frederic Fusier CLA 2006-12-06 13:20:28 EST
Created attachment 55151 [details]
Jar file for tests

This jar file must be put in workspace/JavaSearchBugs/lib directory of org.eclipse.jdt.core.tests.model project to pass added tests in JavaSearchBugsTest
Comment 6 Frederic Fusier CLA 2006-12-06 13:43:31 EST
Released for 3.3 M4 in HEAD stream.
Comment 7 David Audel CLA 2006-12-12 10:31:49 EST
Verified for 3.3M4 with I20061212-0010.