Community
Participate
Working Groups
This is the first cut of the j2me unit plug-in for evaluation. The code is functional but it still needs some work. I18n is not there and of course package names needs to be changes. And there are copyrights missing here and there. Also I do not think we can include the j2meunit framework code directly without the legal process but the code for the com.nokia.j2meunit plugin is derived from existing eclipse code so it can probably be taken in without legal process.
Created attachment 54717 [details] j2meunit plugins
Kevin, could you go through this and report that what is the case. -Arto
The bug is not valid any more on MTJ reboot. Since they, i'm closing it. If you think that it is still applicable let me know and then we can open a new bug to represent it.
Can you elaborate, why is it not valid anymore?
hi Gorkem, the main reason is that we are rebooting MTJ project and now we will follow a different code base (we will base on eclipseME). since that, i'm not sure if this code can be used on the new code base. were you the one that did it? can you confirm that? i'm also changing all bugs states and creating some new ones that will represent better what we are doing right now. if you think this code is applicable i can just reopen the bug based on the initial reboot plan, we will do some refactoring on eclipseME before start to add any new feature. one of the new features that is on the plan is j2meunit. thanks, gustavo
Code depends on eclipse core and JDT, so it should be usable. If you are already have plans/development for j2meunit then you may discard it. This plugin provides wizard and classpath support smiliar to junit functionality.
we don't plan to re-implement j2meunit if it was already done. as there is no dependency with the previous code base, i will reopen the bug and we will see how to include this on MTJ.
diego, can you please check this plugin to see if we can use it on 0.9.1? :) gep
OK, I'll revise this contribution.
Hi Gorkem, I was looking through the code, and seems very useful to be our base code to provide Unit testing on MTJ. We would like to open a new CQ with your contribution, but i would need information about copyright and licensing of the code. Can you provide me this information? I found that you are using "com.nokia.j2meunit" as package, are/were you an Nokia employee? If so, are your employer aware of this contribution? I'm sending you an email with some questions that we must clarify before continuing the contribution process. Thanks Diego
Is the CQ required for existing committers (http://www.eclipse.org/projects/lists.php?list=projectsforcommitter¶m=gercan) Sorry about the copyright notices. I should have put the Nokia copyrights, would you prefer me to do it?
We are checking with the Intellectual Property team if a CQ is necessary. I believe that you don't need to update the copyright notices. I'll do that if we get the clearance to commit this contribution. I'll keep you informed. Thanks Diego (In reply to comment #11) > Is the CQ required for existing committers > (http://www.eclipse.org/projects/lists.php?list=projectsforcommitter¶m=gercan) > > Sorry about the copyright notices. I should have put the Nokia copyrights, > would you prefer me to do it? >
we talked to doug and he said that this is not completely clear on the development process. so it is better just to submit one. we just did it one modification that we plan to do with the code is to use jmeunit instead of j2meunit. jmeunit is a newer project and looking at the wizard's code it seems that it is not going to be complex to change the code after it is approved by eclipse legal to use this other framework. do you think it make sense? thanks, gustavo PS.: thanks for the contribution and sorry for taking so long to work on it. on MTJ reboot we were focusing initially to go through all legal process and do a first release. after the 0.9 release, your contribution was on the top of our task list :) (In reply to comment #11) > Is the CQ required for existing committers > (http://www.eclipse.org/projects/lists.php?list=projectsforcommitter¶m=gercan) > > Sorry about the copyright notices. I should have put the Nokia copyrights, > would you prefer me to do it? >
This contribution was committed to SVN under the org.eclipse.mtj.jmunit plug-in.
Code committed to SVN
bug released into 0.9.1
