Bug 165988 - TcpipSpy borked
Summary: TcpipSpy borked
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.3   Edit
Hardware: PC All
: P3 normal (vote)
Target Milestone: 3.3 M4   Edit
Assignee: JDT-Debug-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-11-27 18:37 EST by Keith Seitz CLA
Modified: 2006-12-14 11:44 EST (History)
0 users

See Also:


Attachments
patch to fix 165988 (1.72 KB, patch)
2006-11-27 18:38 EST, Keith Seitz CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Keith Seitz CLA 2006-11-27 18:37:25 EST
It appears that this patch borked TcpipSpy:

revision 1.17
date: 2005-06-20 16:44:01 +0000;  author: krbarnes;  state: Exp;  lines: +1 -1;
corrected typos.

This occurred because the string modified in TcpIpMessages.properties was pushed over the column maximum hard-coded in VerbosePacketStream.printDescription (32 characters). As a result, the code attempted to pad by -4 bytes, which caused an ArrayIndexOutOfBoundsException in System.arraycopy.

I'm attaching a patch which increases the column descriptor width to 38 (current max is 36) and adds a large warning to TcpIpMessages.properties about double-checking string lengths against printDescription.
Comment 1 Keith Seitz CLA 2006-11-27 18:38:33 EST
Created attachment 54593 [details]
patch to fix 165988
Comment 2 Darin Wright CLA 2006-11-28 11:11:39 EST
Applied patch.
Comment 3 Darin Wright CLA 2006-12-14 11:44:57 EST
Verified.