Bug 165826 - RootEditPart should never have focus for GraphicalViewer
Summary: RootEditPart should never have focus for GraphicalViewer
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 2.0   Edit
Hardware: PC All
: P3 normal
Target Milestone: 2.0   Edit
Assignee: Alex Boyko CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-11-24 16:31 EST by Alex Boyko CLA
Modified: 2008-08-13 13:10 EDT (History)
0 users

See Also:

Attachments
patch (1.57 KB, patch)
2006-11-24 16:33 EST, Alex Boyko CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Boyko CLA 2006-11-24 16:31:16 EST 
RubberbandSelectionTool#clearFocus() method explicitly sets GrpahicaViewer's focus part to RootEditPart, which GEF doesn't expect to happen (per my discussion with Randy on bug 147944).
Instead the focused edit part should be either contents edit part (getCurrentViewer().getContents()) or null.
Comment 1 Alex Boyko CLA 2006-11-24 16:33:31 EST 
Created attachment 54500 [details]
patch

Proposed patch.

Let the contents edit part to be focused by default.
Comment 2 Cherie Revells CLA 2006-11-29 14:23:50 EST 
Committed patch.
Comment 3 Anthony Hunter CLA 2006-12-06 10:57:25 EST 
Have to reopen to assign to Alex
Comment 4 Anthony Hunter CLA 2006-12-06 10:58:18 EST 
resolving again
Comment 5 Richard Gronback CLA 2008-08-13 13:10:48 EDT 
[target cleanup] 2.0 M4 was the original target milestone for this bug
Comment 6 Eclipse Webmaster CLA 2010-07-19 12:30:27 EDT 
[GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug