Bug 165768 - customBuildCallbacks - design error
Summary: customBuildCallbacks - design error
Status: ASSIGNED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: Build (show other bugs)
Version: 3.2.1   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: pde-build-inbox CLA
QA Contact:
URL:
Whiteboard: stalebug
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-24 06:24 EST by Tom Maier CLA
Modified: 2022-11-15 12:31 EST (History)
1 user (show)

See Also:


Attachments
Test case showing the problem (21.24 KB, application/octet-stream)
2007-04-24 16:36 EDT, Pascal Rapicault CLA
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Tom Maier CLA 2006-11-24 06:24:17 EST
You have 2 plugins, both shall use the same customBuildCallbacks.xml, so you write in both plugins build.properties:
customBuildCallbacks=../mydefaultcallbacks/customBuildCallbacks.xml 

Then you have a 3th plugin, that shall use different callbacks, so in this plugins build.properties you write:
customBuildCallbacks=./customBuildCallbacks.xml 

And then you have a feature, that shall use callbacks as well, but whatever you write in this features build.properties, you will end up with this message:

[available] DEPRECATED - <available> used to override an existing property.
[available]   Build file should not reuse the same property name for different values.
Comment 1 Andrew Niefer CLA 2006-11-24 11:02:38 EST
I'm surprised we haven't seen this earlier.  It appears that the plugin's build.xml is inheriting the customBuildCallbacks property from the feature.

Either we figure out how to not have that property inherited, or we need to name them uniquely.  The name would likely need to be based on the name of the feature/plugin since nested features will inherit their parent's property (so simply naming them customFeatureCallbacks and customPluginCallbacks would not be enough).

This appears to be a warning and the callbacks are still being called.
Comment 2 Tom Maier CLA 2006-11-28 05:12:22 EST
> ... since nested features will inherit their parent's property (so
> simply naming them customFeatureCallbacks and customPluginCallbacks 
> would not be enough)

Hmm - that would have been my solution proposal, but it looks like you are right. 

Even more, one of my collegues says, that even plugins can consist of just a list of plugins. (This shall be usefull to create a bundled interface for actually a bunch of plugins.) If so, the inheritance vs. redefinition problem also exists for plugin-of-plugin situations.

Comment 3 Pascal Rapicault CLA 2007-04-24 16:36:46 EDT
Created attachment 64788 [details]
Test case showing the problem

Here is a test case showing the problem. To reproduce, generate the scripts on the feature (f or f2) and then run the script on "build.jars" target on the feature.

Even though the warning is ugly / scary, the attach test case shows that the proper behavior is being executed (see the hello messages printed into the console). Therefore I don't think we should try to fix that for 3.3. 
Ever? this is another question?
Comment 4 Lars Vogel CLA 2018-12-03 09:10:58 EST
Currently we are not actively enhancing PDE build anymore. Therefore, I close this bug as WONTFIX. 

Please reopen, if you plan to provide a fix.
Comment 5 Lars Vogel CLA 2018-12-03 09:13:25 EST
Currently we are not actively enhancing PDE build anymore. Therefore, I close this bug as WONTFIX. 

Please reopen, if you plan to provide a fix.
Comment 6 Eclipse Genie CLA 2020-11-24 08:47:14 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.
Comment 7 Eclipse Genie CLA 2022-11-15 12:31:24 EST
This bug hasn't had any activity in quite some time. Maybe the problem got resolved, was a duplicate of something else, or became less pressing for some reason - or maybe it's still relevant but just hasn't been looked at yet.

If you have further information on the current state of the bug, please add it. The information can be, for example, that the problem still occurs, that you still want the feature, that more information is needed, or that the bug is (for whatever reason) no longer relevant.

--
The automated Eclipse Genie.