Bug 165553 - Regression: CView lost some Drag&Drop functionality support
Summary: Regression: CView lost some Drag&Drop functionality support
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-core (show other bugs)
Version: 3.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.1.2   Edit
Assignee: Doug Schaefer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-11-22 17:32 EST by Alex Chapiro CLA
Modified: 2009-01-09 16:59 EST (History)
3 users (show)

See Also:

Attachments
Patch to fix the problem (7.56 KB, patch)
2007-02-05 16:59 EST, Alex Chapiro CLA 		bjorn.freeman-benson: iplog+
Details | Diff
Patch for 4.0.2 (branch CDT_4_0) (6.55 KB, patch)
2007-10-25 18:21 EDT, Alex Chapiro CLA 		bjorn.freeman-benson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Chapiro CLA 2006-11-22 17:32:56 EST 
In CDT2.1 drop listener (class CViewDropAdapter) inherited PluginDropAdapter. This  implementation provided support for dropping to C/C++ Projects view unknown types (see article Drag and Drop in the Eclipse UI). For example, we uses this feature to drag&drop file objects from the remote target view. 
Then drop listener implementation was changed and all drop listeners do not inherit PluginDropAdapter class and as a result do not support dropping unknown types any more.
I hope it's quite easy to return back this feature to existing implementation.
Comment 1 Alex Chapiro CLA 2007-02-05 16:59:27 EST 
Created attachment 58288 [details]
Patch to fix the problem

I tested it on Windows XP and Linux SUSE GTK.
Comment 2 Doug Schaefer CLA 2007-02-05 20:00:29 EST 
Chris R. can you have someone on your team look at this. I know Rational products used drag 'n drop a lot. I'd be happy to apply the patch. I just want to make sure it doesn't break anyone first.
Comment 3 Doug Schaefer CLA 2007-02-06 13:58:37 EST 
Patch applied now to make sure it gets adequate testing before the final 3.1.2. 

Thanks, Alex.
Comment 4 Chris Recoskie CLA 2007-02-06 14:05:28 EST 
(In reply to comment #2)
> Chris R. can you have someone on your team look at this. I know Rational
> products used drag 'n drop a lot. I'd be happy to apply the patch. I just want
> to make sure it doesn't break anyone first.

Oops... sorry... didn't see this until now.  Janees/Neeraj can you guys test this out?
Comment 5 Alex Chapiro CLA 2007-10-25 18:21:51 EDT 
Created attachment 81211 [details]
Patch for 4.0.2 (branch CDT_4_0)

Can be apply for CDT_4_0