Bug 165050 - Add FORMATTER_INSERT_SPACE_BEFORE_PARENTHESIZED_EXPRESSION_IN_THROW to the code formatter preference page
Summary: Add FORMATTER_INSERT_SPACE_BEFORE_PARENTHESIZED_EXPRESSION_IN_THROW to the co...
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M4   Edit
Assignee: JDT-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 164946
Blocks:
  Show dependency tree
 
Reported: 2006-11-17 16:54 EST by Olivier Thomann CLA
Modified: 2006-11-21 06:47 EST (History)
0 users

See Also:

Attachments
Proposed fix (6.42 KB, patch)
2006-11-17 16:54 EST, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2006-11-17 16:54:29 EST 
Fup of bug 164946, one option existed for return statement, but not for throw statement.
I'll attach a patch for this one.
Comment 1 Olivier Thomann CLA 2006-11-17 16:54:58 EST 
Created attachment 54106 [details]
Proposed fix

It seems to work fine in self hosting.
Comment 2 Martin Aeschlimann CLA 2006-11-20 11:11:34 EST 
released patch (slighly modified) > 20061120

Thanks Olivier!
Comment 3 Olivier Thomann CLA 2006-11-20 14:53:20 EST 
Martin,

What have you modified? I'd like to know in case I submitted new patches in this area. I thought my patch was ready to be released.
Comment 4 Martin Aeschlimann CLA 2006-11-21 04:47:21 EST 
Your patch was fine. You copied how it was done with 'return', but update that:
The syntax element tree had this extra child node
+ 'return'
  + parenthized expressions


I changes it for 'return' and 'throws' to:
+ 'return' with parenthized expressions
Comment 5 Martin Aeschlimann CLA 2006-11-21 06:47:21 EST 
..but I updated that:...