Community
Participate
Working Groups
I am going to attach a sample implementation for a remote connection field editor and a remote location field editor. These field editors can be used in preference pages and by using the mechanisms described in http://www.eclipse.org/articles/Article-Mutatis-mutandis/overlay-pages.html to use them in property pages as well. I'll attach a sample plugin project that contains the code.
Created attachment 54054 [details] sample project (zip) I, Lothar Werzinger, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. I am authorized by my employer to make this contribution under the EPL.
The only thing I could not get to work is to get the remote file dialog to preselect the file/directory. I set the preselection, but it does not have any effect. If anybody knows how to fix that, please tell me :-)
Thanks a lot for this contribution. I tried it out, and I have several questions / suggestions. 1)If we are to accept the code into the repository, it will need to go through Eclipse Legal Review, since it is more than 250 lines of code in size. For this review to succeed, it will need to have proper Copyright notices everywhere. Currently, - Some files do not have a copyright notice at all - The others are missing the Contributor name This needs to be fixed and re-submitted before we can accept the code 2)I like the concept of the field editors, but why are only SSH Connections supported in the SamplePreferencePage? -- Just any connection supporting an IRemoteFileSubSystem should be supported, since there are abstract APIs for the file services available. In fact, most of the code looks like it should work with this relaxed prerequisite already, so why is there this artificial limitation? In particular, for testing purposes the "Local" system type should be supported. 3)The Sample Preference Page should be under the "Remote Systems" Category 4)I think the field editors themselves should go into org.eclipse.rse.ui/UI/org.eclipse.rse.ui.propertypages or - even better yet - org.eclipse.rse.ui/UI/org.eclipse.rse.ui.preference while the sample Preference page should go into org.eclipse.rse.examples.tutorial/src/samples.ui.preference 5)Would you consider also adding some documentation to org.eclipse.rse.docs.isv/guide/tutorial describing the sample preference page? A single doc page would probably be enough. --- I consider (1)-(3) a must-have for accepting the contribution. This should not be too much work, and re-submitting a new ZIPed contribution would allow us to use this example already for educational purposes. For (4) - adding the field editors to Core RSE, I'd like to get some input from other RSE developers. Since this would also be more effort, would you be willing to spend this extra effort and resubmit?
