Bug 164800 - Plugins tree is not disabled for USEFEATURES mode when launch dialog is opened
Summary: Plugins tree is not disabled for USEFEATURES mode when launch dialog is opened
Status: RESOLVED FIXED
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M4   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-11-16 07:06 EST by Alexei Alexandrov CLA
Modified: 2007-06-05 18:33 EDT (History)
1 user (show)

See Also:

Attachments
plugintree.diff (782 bytes, patch)
2006-11-16 16:05 EST, Benjamin Muskalla CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alexei Alexandrov CLA 2006-11-16 07:06:37 EST 
Reproduce: create a PDE launch configuration with "Use features in the workspace" mode enabled. The tree with plugins is disabled. Close the configuration dialog and open it again. You will see that the tree with plugins is not disable while it's supposed to.
Comment 1 Benjamin Muskalla CLA 2006-11-16 07:59:01 EST 
Reproducable on Gentoo Linux, GTK.

Will provide a patch in the next hours.
Comment 2 Benjamin Muskalla CLA 2006-11-16 16:05:19 EST 
Created attachment 54022 [details]
plugintree.diff

Attaches is a patch which should fix the bug. Patch is against current HEAD.
Comment 3 Brian Bauman CLA 2006-11-16 17:06:34 EST 
Benjamin, thanks for the patch.

I am releasing it with a minor modification.  Instead of explicitly calling PluginBlock.enableViewer() after calling PluginBlock.initializedFrom(..), I added an extra boolean parameter to the PluginBlock.initializeFrom function for the value of fUseListRadio.getSelection().  

I did this so we don't call enableViewer twice when initializing.  This should help performance and prevent any flickering on slower machines.  

Should be in 3.3M4.