Bug 164450 - [comments] DefaultCommentMapper should release scanner after use
Summary: [comments] DefaultCommentMapper should release scanner after use
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.2   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M4   Edit
Assignee: Frederic Fusier CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
Depends on:
Blocks:
 
Reported: 2006-11-14 06:29 EST by Martin Aeschlimann CLA
Modified: 2006-12-12 06:16 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Aeschlimann CLA 2006-11-14 06:29:01 EST 
20061114
If I understand right, the scanner used in the DefaultCommentMapper is only used when computing the ranges.
All accesses to extended ranges are simple lookups in an array on no use of the scanner is required.

The scanner still holds the char[] of the soirtce content which can be quite big.
Comment 1 Frederic Fusier CLA 2006-11-17 10:46:40 EST 
Fixed in method DefaultCommentMapper#initialize(CompilationUnit, Scanner).
Released for 3.3 M4 in HEAD stream.
No test case added.
Comment 2 David Audel CLA 2006-12-12 06:16:01 EST 
Verified for 3.3M4 with I20061212-0010.