Bug 164449 - [content assist] Only call ICodeAssist.codeComplete(...) once
Summary: [content assist] Only call ICodeAssist.codeComplete(...) once
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Text (show other bugs)
Version: 3.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.5 M3   Edit
Assignee: Dani Megert CLA
QA Contact:
URL:
Whiteboard:
Keywords: performance
: 247809 (view as bug list)
Depends on:
Blocks: 248864
  Show dependency tree
 
Reported: 2006-11-14 06:07 EST by Dani Megert CLA
Modified: 2008-09-28 09:27 EDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dani Megert CLA 2006-11-14 06:07:04 EST 
3.2 and 3.3 M3

JDT Text calls JDT Core code assist twice on each invocation. This happens because the final proposal list is computed by several different completion processors. Two of them (the "no type" and the "other proposals" processor) call ICodeAssist.codeComplete(...).

Note that this is not a bug but works as designed since we eat our own dog food by contributing the processor via extension point. We could however try to improve the performance by providing an internal processor that only combines the two and only calls JDT Core once.
Comment 1 Dani Megert CLA 2006-11-14 06:09:30 EST 
Time permitting for 3.3.
Comment 2 Dani Megert CLA 2006-11-14 06:24:21 EST 
I knew there was a bug for that but thought this was captured in the constructor proposal bug.

*** This bug has been marked as a duplicate of 162923 ***
Comment 3 Dani Megert CLA 2008-09-18 08:42:41 EDT 
Reopening to see whether we can at least solve the concrete issue.
Comment 4 Dani Megert CLA 2008-09-18 08:43:06 EDT 
*** Bug 247809 has been marked as a duplicate of this bug. ***
Comment 5 Dani Megert CLA 2008-09-18 10:58:56 EDT 
I have something in mind that would fix this issue unless a user goes and changes the preference in a way that two calls happen again.
Comment 6 Dani Megert CLA 2008-09-19 02:49:41 EDT 
Fixed in HEAD.
Available in builds >= I20080923-0800.