Community
Participate
Working Groups
New Connection wizard Select System Type page no longer honors default system type settings in preferences for Remote Systems. In preference->Remote Systems, user can specify the "Default System Type" settings. And in the old New Connection wizard (with list of system types displayed instead of drop down), the default stystem type will be selected as default when user try to create a new connection. But in the new "Select System Type" page of the wizard, the first system type is always selected and the default system type setting is ignored.
Good catch! My personal feeling is, though, that a better solution would be to simply remember the previous selection in the New Connection Wizard. Most Eclipse "New" wizards work that way -- e.g. New Project. This seems to be a more natural approach to me, and it would perhaps allow us to get rid of the "Default System Type" Preference page. Yu-Fen, if you agree please change the Summary of this bug to "New Connection Wizard should remember previous selection".
I'd prefer to keep the existing "Default System Type" functionality. Since vendors can plugin their own "System Type" thru rse extensions, when creating a new connection, usually they expect their user to be using their own "System Type" and without the "Default System Type" preference, there is no way for vendor's plugin code to set the default settings of system type for their user.
I'm still not so convinced about the "default system type" concept. * You can only select a single default system type. What if a vendor (like us) contributes multiple system types? - I think that eventually - RSE should support grouping system types by category, just like the Eclipse New Project Wizard does. Then, there would be a category "Default", another one "Windriver", a third one "Montavista". Users would find the right system type more easily. - RSE should use Eclipse Capabilities to allow vendors to hide system types that their users are not expected to see by default. * Vendors cannot foresee what users want to do. It's more user-friendly to remember the previous decision - and it's more consistent with what Eclipse does. Sorting out the right thing will take until after 1.0.1. If you think you'll need the "default system type" concept in RSE 1.0.1 for your product, please comment here again.
For TM 2.0M5, the new connection wizard has been rewritten to make use of the Eclipse Platform WizardSelectionPage. The wizard does now support Categories for system types, and the default selection is always the one that was selected previously (just like in the Eclipse New Project Wizard). I think that this solution is the right one. Since the "Default System Type" has no meaning any more, I think it should be removed from the Preference page. Please comment here on that plan.
+1 to remove it from the preferences. Additional it should be checked where the SystemHostCombo is used in other places and if still make sense. The control is part of the system connection form but not utilized in there.
(In reply to comment #4) > For TM 2.0M5, the new connection wizard has been rewritten to make use of the > Eclipse Platform WizardSelectionPage. The wizard does now support Categories > for system types, and the default selection is always the one that was selected > previously (just like in the Eclipse New Project Wizard). > > I think that this solution is the right one. > > Since the "Default System Type" has no meaning any more, I think it should be > removed from the Preference page. Please comment here on that plan. > A word of caution: This preference is used at least one place in the code in other than its use as the default for the former wizard. These need to be examined as to why they are used that way before we can remove the value from the preference page, the preference store, or preferences API.
Kushal (and Dave) - we just got bug 176483 which asks why the default of the default system type combo in preferences is empty. We've been considering removing the "default system type" combo before but you were unsure if this is possible. Could you please investigate if it is possible to remove the "default system type" combo. Since this would be an NLS changing thing, we should consider this for M6.
We agreed that the combo (and associated API in RSEPreferencesManager) should be removed for M6, but NL Strings should be kept for now.
Removed combo from preference page and associated preference constants and methods, but kept the NL strings. I have not noticed any problems.
This is an API change since RSEPreferencesManager.getSystemType() RSEPreferencesManager.setSystemType() are also removed. Migration guide for extenders: If your code uses these methods, consider a different way of choosing a default system type. For instance, the first of all registered types; or the type previously selected in a form. Future versions of RSE will use Capabilities / Activities to allow limiting the list of visible system types, such that extenders can tune their product by hiding system types that should not be shown. Right now, this can be done by deactivating a system type in the Preferences (through plugin_customization.ini).
Verified with I20070405-0600. Closing.
[target cleanup] 2.0 M6 was the original target milestone for this bug
