Bug 164081 - XML log could contain package information
Summary: XML log could contain package information
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.3 M4   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-11-10 03:45 EST by Philipe Mulet CLA
Modified: 2006-12-13 03:31 EST (History)
0 users

See Also:

Attachments
Proposed fix (5.60 KB, patch)
2006-11-10 14:26 EST, Olivier Thomann CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philipe Mulet CLA 2006-11-10 03:45:51 EST 
Build 3.3M3

I propose adding more information in xml log to tell about package name etc...
BEFORE:
		<source path="d:\eclipse\bench\swt\Decorations.java">
			<classfile path="D:\eclipse\bench\out\org\eclipse\swt\widgets\Decorations.class"/>
		</source>

AFTER:
		<source path="d:\eclipse\bench\swt\Decorations.java" output="d:\eclipse\bench\out" package="org\eclipse\swt\widgets">
			<classfile path="D:\eclipse\bench\out\org\eclipse\swt\widgets\Decorations.class"/>
		</source>
Comment 1 Olivier Thomann CLA 2006-11-10 14:26:09 EST 
Released for 3.3M4.

If the compilation unit is within the default package, the package attribute is removed.
If the compilation unit has no output folder, the output attribute is removed.

The DTD has been modified to replace:
<!ATTLIST source path    CDATA #REQUIRED>
with:
<!ATTLIST source path    CDATA #REQUIRED
                 output  CDATA #IMPLIED
                 package CDATA #IMPLIED>

This should be compliant with the previous version.
Comment 2 Olivier Thomann CLA 2006-11-10 14:26:27 EST 
Created attachment 53646 [details]
Proposed fix
Comment 3 Olivier Thomann CLA 2006-11-10 14:26:58 EST 
Released for 3.3M4.
Comment 4 Frederic Fusier CLA 2006-12-13 03:31:01 EST 
Code verified for 3.3 M4 using v_727.