Community
Participate
Working Groups
Changing a filter definition for a file subsystem should allow one to specify multiple filter strings. This should be re-enabled.
Defer until after R1.
Kushal -- Can you handle this one? I actually saw a change... dialog that showed multiple filter strings, but when I tried to bring it up again it didn't show up. This was on the latest stuff in the head stream.
This is working for my on the latest driver I20070516-1300.
This problem was easily reproducible in the past but I don't see the problem anymore either.
Just saw this again on driver I20070713-0605. Not sure how to reproduce it, but it happened to me twice where it didn't show the multiple filter strings. Restarting the workbench didn't fix it. I had to create a new workspace. I wasn't even creating filters when this happened. I was just testing search, scratchpad, and table view. Then hit alt enter on my home by accident and saw it. Martin/Dave, please reopen this.
reopen as requested by Kevin
Assigning Kevin since you could see it happen - could you have a look?
This looks to be a persistence issue. I've found out how to recreate it all the time. Start with a clean workspace. Use the workspace twice and on the third time multi strings will be gone. Steps to Reproduce: 1. Start with a clean workspace. 2. Check the filters on Local still have multiple filter strings. 3. Restart the workspace. 4. Check the filters on Local still have multiple filter strings. 5. Restart the workspace. 6. Filters no longer have multiple filter strings.
Created attachment 74087 [details] Changes to RSEDOMImporter and RSEDOMExporter so we persist the proper values Dave's as discussed I have added a new attribute for persisting, so we save the singleFilterStringOnlyESet value. Import works like this now. If the new attribute (singleFilterStringOnlyESet) exists then if it's true call the proper method to restore the singleFilterStringOnly. If it's false then we don't make the call as it's false by default. If the new attribute doesn't exist then we don't set singleFilterStringOnly. Which will cause singleFilterStringOnlyESet to be false, so it will check with the filter pool manager if multiple filter strings should be shown. Legal Message: I, Kevin Doyle, declare that I developed attached code from scratch, without referencing any 3rd party materials except material licensed under the EPL. I am authorized by my employer, IBM Canada Ltd. to make this contribution under the EPL.
Not sure what changes went in to change the steps to reproduce the original problem, but here are the new steps: 1. Start with a clean workspace. 2. Check the filters on Local still have multiple filter strings. 3. Restart the workspace. 4. Create a new connection. -- Force a save of profile. 5. Check the filters on Local still have multiple filter strings. 6. Restart the workspace. 7. Filters no longer have multiple filter strings.
You can also use the original steps as long as you click Okay to close the Properties page when looking at the Filter Strings as this will save the profile as well.
Kevin do your new steps mean that you can still reproduce the issue even with your patch applied, or does your patch fix the issue? - Assigning to DaveD now since he'd be the next one to act on this by reviewing and potentially applying the patch. Changed the Summary (old value:"Multiple filter strings are disabled") and setting Severity NORMAL since it's reproducable always as per comment #8 and comment #10.
Kevin is the patch safe against operating on an old workspace? Once a profile is saved with the patch, can RSE without patch still read it?
The patch fixes the issue. The steps to reproduce the issue are for creating a workspace that's persisted state is incorrect. This way we can test the patch on old workspaces as well as new workspaces. I have tested this on an old workspace and it works fine. The multiple filter strings will come back as it will check with the filter pool manager to decide if multiple filter strings are allowed. RSE without the patch using a workspace that was saved with the patch should work fine. I haven't tested this though. I'll try that shortly to make sure and let you know.
(In reply to comment #13) > Once a profile is saved with the patch, can RSE without patch still read it? I've tested this and it works fine.
Applied Kevin's patch. Tested. Made some minor style changes. This patch will re-enable the use of multiple filter strings if used on older workspaces. Profiles in workspaces created with this patch should function as they did before this patch was applied. There should be no compatibility problems.
