Bug 163377 - [CView] CView does not reveal new resources
Summary: [CView] CView does not reveal new resources
Status: RESOLVED FIXED
Alias: None
Product: CDT
Classification: Tools
Component: cdt-core (show other bugs)
Version: 3.1.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 4.0 M5   Edit
Assignee: Anton Leherbauer CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks: 163578
  Show dependency tree
 
Reported: 2006-11-03 15:02 EST by Sascha Radike CLA
Modified: 2009-01-09 15:03 EST (History)
0 users

See Also:

Attachments
Patch (2.64 KB, patch)
2006-11-03 15:03 EST, Sascha Radike CLA 		bjorn.freeman-benson: iplog+
Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sascha Radike CLA 2006-11-03 15:02:07 EST 
The CView does not reveal new resources which have been created by a wizard (resulting in a call to CView.selectReveal(ISelection).

The CView does only reveal elements of the selection which can be converted to CElements, but it does not reveal simple resources like IFile, IFolder, ... .

Reason:
CView.selectReveal(ISelection) calls SelectionConverter.convertSelectionToCElements - which converts objects of the selection to celements and ignores non-c resources.

See attached patch for changes. They are very small, so I think there is no need for further comments. I added an option to the selection converter which allows non-c elements, which cannot be converted, to be kept in the selection.
Comment 1 Sascha Radike CLA 2006-11-03 15:03:20 EST 
Created attachment 53228 [details]
Patch
Comment 2 Anton Leherbauer CLA 2006-11-06 03:56:22 EST 
Sounds reasonable. I'll have a look.
Comment 3 Anton Leherbauer CLA 2006-11-06 05:10:07 EST 
Applied to 4.0 > 20061106. 
Thanks for the patch!
Comment 4 Sascha Radike CLA 2006-11-06 08:54:37 EST 
Great :-) But why not apply to 3.1.2 ? I think this is more important for 3.1.2 than 4.0 anyway (since 4.0 might use the common navigator).
Comment 5 Anton Leherbauer CLA 2006-11-06 11:51:56 EST 
You're right. Applied also to 3.1.2.
Comment 6 Doug Schaefer CLA 2006-11-06 14:08:21 EST 
I have marked the clone of this bug as fixed. I'll leav this on 4.0 since it has the patch attached and I need it for the release review.