Bug 163349 - [assist] code assist doesn't correctly use scanner eofPosition
Summary: [assist] code assist doesn't correctly use scanner eofPosition
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M4   Edit
Assignee: David Audel CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 161400
  Show dependency tree
 
Reported: 2006-11-03 11:26 EST by David Audel CLA
Modified: 2006-12-11 14:22 EST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Audel CLA 2006-11-03 11:26:46 EST
Completion engine use the fact that the scanner doesn't really stop to scan at Scanner.eofPosition.

If completion is inside a method body then completion engine intialize the scanner eofPostion at the location the completion. But it use the fact that the scanner will scan util the end of the current token.
e.g. fo|o = null;
the eofPosition will be at | but the scanner will scan until the end of foo. The completion engine use this position as the end of the completion token.

This can be considered as a non correct use and a fix to bug 161400 will change this property of the scanner.
Completion process should be adapted to support the fix of 161400.
Comment 1 Olivier Thomann CLA 2006-11-03 11:31:18 EST
Both fixes should be released at the same time.
Comment 2 Olivier Thomann CLA 2006-11-06 16:44:30 EST
Released for 3.3M4.
David, I released since I released the code for bug 161400.
Comment 3 Olivier Thomann CLA 2006-12-11 14:22:04 EST
Verified for 3.3M4 with I20061211-1119