Bug 163347 - [clean up] Clean up doesn't follow formatter options
Summary: [clean up] Clean up doesn't follow formatter options
Status: RESOLVED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: All All
: P3 normal (vote)
Target Milestone: 3.3 M5   Edit
Assignee: Benno Baumgartner CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on: 49412
Blocks:
  Show dependency tree
 
Reported: 2006-11-03 11:20 EST by John Arthorne CLA
Modified: 2007-02-02 10:58 EST (History)
2 users (show)

See Also:


Attachments
fix (18.89 KB, patch)
2007-02-02 10:39 EST, Benno Baumgartner CLA
no flags Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Arthorne CLA 2006-11-03 11:20:25 EST
3.3 M3

I enabled Clean up on save, and used the default save participant profile.  When I started using it, I noticed that it was formatting my comments, even though my active formatter profile says comments should not be formatted. When I investigated I noticed that the clean up profile has a separate check box for "format comments".  Why have a separate option for this when it is already part of the general formatter profile? The expected behaviour is that my formatter settings will always be obeyed...
Comment 1 Dani Megert CLA 2006-11-04 04:50:00 EST
Not related to clean up on save but a general "clean up" issue.
Comment 2 Martin Aeschlimann CLA 2006-11-08 12:08:24 EST
the request makes sense, I guess it's better to reuse the settings as specified in the formatter profile.
Comment 3 Benno Baumgartner CLA 2006-11-09 10:46:38 EST
Ok, I can do that. But remember, that the formatter settings do not allow to specify which kind of comment to format (See Bug 49412). On clean up you can turn on/off formatting of Javadoc, single line, and multi line comments. I think formatting javadoc on safe makes sense, formatting single line comments certainly not. I think fixing Bug 49412 first would make more sense and init the clean up comment formatting setting with the formatter setting in the meantime.
Comment 4 John Arthorne CLA 2006-11-09 10:59:14 EST
Fixing bug 49412 makes sense... then you on the clean up wizard you just need a "Format code" checkbox, and get rid of the comment formatting checkboxes. (or have a combo that alway me to select a formatter profile to use for this particular cleanup, if you want different formatter settings for cleanup from regular format command)
Comment 5 Tod Creasey CLA 2006-11-27 09:55:09 EST
This doesn't look like a Vista specific issue
Comment 6 Benno Baumgartner CLA 2007-02-02 10:39:21 EST
Created attachment 58119 [details]
fix
Comment 7 Benno Baumgartner CLA 2007-02-02 10:58:28 EST
fixed > I20070130-0800