Bug 163123 - ScalableImageFigure image is cut off when aspect ratio is respected
Summary: ScalableImageFigure image is cut off when aspect ratio is respected
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0.1   Edit
Hardware: PC Windows XP
: P3 normal
Target Milestone: 1.0.3   Edit
Assignee: Alex Boyko CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-11-01 14:41 EST by Alex Boyko CLA
Modified: 2006-12-06 11:10 EST (History)
0 users

See Also:

Attachments
patch (3.16 KB, patch)
2006-11-01 14:52 EST, Alex Boyko CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Boyko CLA 2006-11-01 14:41:58 EST 
A client application has images from ScalableImageFigure cut off when original aspect ratio is obeyed. The problem seems to be coming from the calculation of scale factors for the image to be rendered in:
org.eclipse.gmf.runtime.draw2d.ui.render.internal.image.ImageRenderedImage#renderImage()

and

org.eclipse.gmf.runtime.draw2d.ui.render.awt.internal.svg.SVGImage.renderImage()

methods.

Seems like on of the conditions needs a slight improvement.
Comment 1 Alex Boyko CLA 2006-11-01 14:52:15 EST 
Created attachment 53100 [details]
patch

Improved the condition as specified in the bug.
Comment 2 Cherie Revells CLA 2006-11-20 17:15:19 EST 
I committed the patch for Alex:
[163123] gmf_R1_0_maintenance crevells 061120 ScalableImageFigure image is cut off when aspect ratio is respected
[163123] gmf_head crevells 061120 ScalableImageFigure image is cut off when aspect ratio is respected
Comment 3 Anthony Hunter CLA 2006-12-06 11:08:32 EST 
reopen to assign to Alex
Comment 4 Anthony Hunter CLA 2006-12-06 11:10:12 EST 
resolving again
Comment 5 Eclipse Webmaster CLA 2010-07-19 12:30:27 EDT 
[GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug