Bug 163070 - Importing required plug-ins wants to replace exisiting source plug-ins
Summary: Importing required plug-ins wants to replace exisiting source plug-ins
Status: RESOLVED WORKSFORME
Alias: None
Product: PDE
Classification: Eclipse Project
Component: UI (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: ---   Edit
Assignee: PDE-UI-Inbox CLA
QA Contact:
URL:
Whiteboard:
Keywords: bugday
Depends on:
Blocks:
 
Reported: 2006-11-01 10:15 EST by Markus Keller CLA
Modified: 2007-12-13 12:02 EST (History)
2 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Markus Keller CLA 2006-11-01 10:15:26 EST
I20061031-0656

Importing required plug-ins wants to replace exisiting source plug-ins

Steps:
- new workspace
- import plug-ins in source:
org.eclipse.jdt.apt.core
org.eclipse.jdt.apt.ui
org.eclipse.jdt.core

- File > Import > Plug-ins..., select "... required by existing ..." and "Binary Projects"
- press Next, Select All

=> The list on the right contains org.eclipse.jdt.apt.core and org.eclipse.jdt.core. When pressing Finish, I'm being asked whether I want to replace those plugins.
=> Expected: existing non-binary plug-ins should not be imported again.
Comment 1 bartosz michalik CLA 2007-11-19 10:43:30 EST
I don't agree. there should be a option to override source plug-ins with binary version. But I can agree that option to not override source plugins can be useful (maybe some checkbox will be ok ?)

I can work on this bug ;) But lets make first things first and decide how to implement this option.
Comment 2 Markus Keller CLA 2007-11-19 11:02:39 EST
I selected "Importing plug-ins and fragments required by existing workspace plug-ins" on the page before, so it makes little sense to replace two of the three plug-ins by their binary version (note that apt.ui is NOT on the list to import, and I also cannot add it manually).

Another checkbox would be overkill. If you want to replace all existing imported plug-ins by binary version, use the "Select from ..." option on the first page and  then click "Existing Unshared".
Comment 3 Brian Bauman CLA 2007-12-05 16:12:07 EST
One of the things we strive for in PDE is flexibility.  We can quickly get into problems where we follow one use case or belief too closely which angers users who do things differently.

It seems for your use case that source plug-ins are more valuable than binary plug-ins.  I understand how this might be more helpful in some development environments.

Though I could think of a case when a developer might want to over right their plug-in's dependencies with binary equivalents.  For instance, I might be trying to do some modifications to debug a problem in jdt.core.  Afterwards, when I am done I might then want to work on jdt.ui.  After importing jdt.ui, I may want to have any of my changes I no longer need in jdt.core erased.  The easiest way is to do a binary import for all its dependencies.

In an effort to not restrict users, we should leave this one as is.  If you don't want to over write existing source projects, you can select "No to All" when the prompt to over write an existing project comes up.  If the user wants to replace the source projects with the original binary data, they can simply click "Yes to All".
Comment 4 Brian Bauman CLA 2007-12-13 12:02:26 EST
Updating status, see comment #3