Bug 162932 - [NoteTextLabel] WrapLabel should use Gef's text layout
Summary: [NoteTextLabel] WrapLabel should use Gef's text layout
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0   Edit
Hardware: PC Windows XP
: P3 enhancement
Target Milestone: 2.1   Edit
Assignee: Cherie Revells CLA
QA Contact:
URL:
Whiteboard:
Keywords: plan
Depends on:
Blocks: 194944
  Show dependency tree
 
Reported: 2006-10-31 11:40 EST by Mohammed Mostafa CLA
Modified: 2008-08-13 13:08 EDT (History)
3 users (show)

See Also:

Attachments
Patch for GMF (6.90 KB, patch)
2006-12-15 17:00 EST, Syed Atif CLA 		no flags Details | Diff
Patch for GMF (including new WrapLabel) (172.80 KB, patch)
2006-12-15 17:02 EST, Syed Atif CLA 		no flags Details | Diff
Describes design, code changes, affects on clients, and migration (340.00 KB, application/octet-stream)
2007-10-16 11:05 EDT, Cherie Revells CLA 		no flags Details
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mohammed Mostafa CLA 2006-10-31 11:40:19 EST 
GMF WrapLabel implements the wrapping functionality, this should be refactored to use Gef's text layout instead of re-implmenting the functionality 

good starting point will be to take a look at the Gef's exmaple WYSIWYG
Comment 1 Syed Atif CLA 2006-12-15 17:00:24 EST 
Created attachment 55793 [details]
Patch for GMF

Patch for GEF side.
Comment 2 Syed Atif CLA 2006-12-15 17:02:59 EST 
Created attachment 55794 [details]
Patch for GMF (including new WrapLabel)

This patch is for GMF.

Note typo, the previous patch was for GEF, not GMF.
Comment 3 Richard Gronback CLA 2007-05-07 10:40:55 EDT 
Updated target milestone.
Comment 4 Cherie Revells CLA 2007-10-16 10:11:49 EDT 
- Committed the new WrappingLabel, TextCompartmentEditPart, and TextDirectEditManager enhancements.  I'll update the What's New for 2.1 section with some documentation.
- Committed code in diagram.ui.tests plugin which will add a Label Drawer to the palette and a properties page for shapes with Labels so that the different settings available on a label are testable in some way.
Comment 5 Cherie Revells CLA 2007-10-16 11:05:59 EDT 
Created attachment 80456 [details]
Describes design, code changes, affects on clients, and migration

I have attached a document which discusses the design, gives an overview of the changes made, and provides documentation for the clients on how to use the new WrappingLabel.
Comment 6 Ed Willink CLA 2007-11-20 07:09:57 EST 
Presumably the code generator still (M3) needs enhancement to use WrappingLabel and so not generate numerous deprecations. Or does the document just need a section explaining how existing gmfgen files need upgrading?
Comment 7 Cherie Revells CLA 2007-11-20 09:03:50 EST 
Edward, you are correct -- the GMF code generation team still needs to adopt the new WrappingLabel.  See Bug 206582 .
Comment 8 Richard Gronback CLA 2008-08-13 13:08:17 EDT 
[target cleanup] 2.1 M3 was the original target milestone for this bug
Comment 9 Eclipse Webmaster CLA 2010-07-19 12:30:27 EDT 
[GMF Restructure] Bug 319140 : product GMF and component Runtime Diagram was the original product and component for this bug