Bug 162762 - [DeleteFromSupport] Deleting a connection whose source/target is canonical automatically deletes the element
Summary: [DeleteFromSupport] Deleting a connection whose source/target is canonical au...
Status: NEW
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0.1   Edit
Hardware: PC Windows XP
: P3 normal
Target Milestone: 2.1   Edit
Assignee: Anthony Hunter CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-30 11:16 EST by Cherie Revells CLA
Modified: 2010-07-19 21:56 EDT (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Cherie Revells CLA 2006-10-30 11:16:56 EST 
Let's say you had the following scenario...
On a non-canonical diagram, you have a non-canonical shape that contains
canonical border item.  There is a non-canonical connection from the border
item to another shape.  If you delete the connection with the delete key, you
would expect it to just be deleted from the diagram, but instead it deletes the
relationship from the model.

The reason is that ConnectionEditPolicy.shouldDeleteSemantic() returns true if
one of the ends is canonical.  Actually, it should figure out if the connector
itself is canonical.
Comment 1 Cherie Revells CLA 2006-10-31 10:53:41 EST 
I already committed a fix that modifies the behavior of the ConnectionEditPolicy and DeleteFromDiagramAction so that the semantic element is deleted only if both source and target's containers are canonical.  This is still not the real correct behavior, so I will leave this bugzilla open.

We need to figure out a way if the connection will be created canonically to really fix this.
Comment 2 Anthony Hunter CLA 2007-06-19 11:44:49 EDT 
Moving to the next release, GMF 2.1.
Comment 3 Eclipse Webmaster CLA 2010-07-19 21:56:27 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime was the original product and component for this bug