Bug 162464 - Path Maps preference page uses wrong colours
Summary: Path Maps preference page uses wrong colours
Status: RESOLVED FIXED
Alias: None
Product: GMF-Runtime
Classification: Modeling
Component: General (show other bugs)
Version: 1.0.1   Edit
Hardware: PC All
: P3 normal
Target Milestone: 2.0   Edit
Assignee: Christian Damus CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-10-26 14:21 EDT by Anthony Hunter CLA
Modified: 2010-07-19 21:55 EDT (History)
1 user (show)

See Also:

Attachments
The table we are taling about (45.57 KB, image/png)
2006-10-26 14:23 EDT, Anthony Hunter CLA 		no flags Details
Patch to use a lock icon instead of colours (4.43 KB, patch)
2007-02-07 18:46 EST, Christian Damus CLA 		no flags Details | Diff
mylar/context/zip (33.78 KB, application/octet-stream)
2007-02-07 18:46 EST, Christian Damus CLA 		no flags Details
Lock icon (573 bytes, patch)
2007-02-07 18:51 EST, Christian Damus CLA 		no flags Details | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Anthony Hunter CLA 2006-10-26 14:21:46 EDT 
For whatever reason, the author of the path maps preference page has chosen to use custom colours in the two lists.

This does not meet the accessibility requirements for colours.

We need to not override the default colours for the tables.
Comment 1 Anthony Hunter CLA 2006-10-26 14:23:26 EDT 
Created attachment 52780 [details]
The table we are taling about
Comment 2 Christian Damus CLA 2007-02-07 18:46:34 EST 
Created attachment 58503 [details]
Patch to use a lock icon instead of colours
Comment 3 Christian Damus CLA 2007-02-07 18:46:36 EST 
Created attachment 58504 [details]
mylar/context/zip
Comment 4 Christian Damus CLA 2007-02-07 18:51:56 EST 
Created attachment 58505 [details]
Lock icon

Attached a lock icon to be put in the /icons/full/ folder of the org.eclipse.gmf.runtime.emf.ui plug-in and a patch to the code to use this new icon instead of colours to indicate non-editable entries in the path map table.  The icon, being a binary file, could not be included in the patch.
Comment 5 Christian Damus CLA 2007-02-07 18:52:59 EST 
Comment on attachment 58504 [details]
mylar/context/zip

Obsolete the accidentally added Mylar context.
Comment 6 Christian Damus CLA 2007-02-09 13:18:56 EST 
Hi, Cherie, Anthony,

Could one of you please review the patch?
Comment 7 Cherie Revells CLA 2007-02-09 14:43:42 EST 
Committed the patch.
Comment 8 Richard Gronback CLA 2008-08-13 13:11:00 EDT 
[target cleanup] 2.0 M5 was the original target milestone for this bug
Comment 9 Eclipse Webmaster CLA 2010-07-19 21:55:31 EDT 
[GMF Restructure] Bug 319140 : product GMF and component
Runtime Common was the original product and component for this bug