Bug 162399 - Problem in the implementation of the support of JSR-045
Summary: Problem in the implementation of the support of JSR-045
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Debug (show other bugs)
Version: 3.2.1   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M5   Edit
Assignee: Darin Wright CLA
QA Contact:
URL:
Whiteboard:
Keywords: contributed
Depends on:
Blocks:
 
Reported: 2006-10-26 09:04 EDT by Yavor Boyadzhiev CLA
Modified: 2007-02-01 10:29 EST (History)
1 user (show)

See Also:

Attachments
manage situation when OutputLineIncrement is 0 (958 bytes, patch)
2006-10-26 09:30 EDT, Yavor Boyadzhiev CLA 		no flags Details | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Yavor Boyadzhiev CLA 2006-10-26 09:04:26 EDT 
Suppose we have the JSP file: 

testSimpleTag.jsp:[<%@ page import="java.io.*" %> some string here]
 
The valid SMAP for this JSP is:
SMAP 
JEE_jsp_testSimpleTag_24890350_1152694486531_1152694491765.java
JSP 
*S JSP 
*F 
+ 0 testSimpleTag.jsp 
testSimpleTag.jsp 
*L 
1:38,0 
*E 

We use page directive before the String in order to be able to put a breakpoint on this line, otherwise eclipse offers to add a bookmark. The right behavior of the debugger should be when the jsp execution hits the breakpoint the IDE to stop on this line. However this does not happen. So the problem here is that although the SMAP is valid and a breakpoint is set on this single line of the JSP, when the JSP page is requested eclipse does not stop on this breakpoint.
Comment 1 Yavor Boyadzhiev CLA 2006-10-26 09:30:30 EDT 
Created attachment 52744 [details]
manage situation when OutputLineIncrement is 0

In the ReferenceTypeImpl.getOutputLinesForLine(int lineNumber) if OutputLineIncrement is 0 then didn’t add line in the list.
Comment 2 Darin Wright CLA 2007-02-01 09:59:37 EST 
Applied patch.
Comment 3 Darin Wright CLA 2007-02-01 10:00:21 EST 
Verified.