Community
Participate
Working Groups
The method implementation is not symetrical. What it does is to check whether its parameters have equal return types, or else if the first one has a return type compatible with the one of the second one, under specific conditions (one of these conditions being that the caller be an instance of MethodVerifier15). Unfortunately, areReturnTypesCompatible already exists... Hence clarification of the topic is needed before any action is taken.
A couple of remarks: - the only uses (in JDT Core - but method verifiers are non-API classes) of the existing areReturnTypesCompatible are in implementations of areReturnTypesEqual; - areReturnTypesEqual is called from inheritance verification code and from areMethodsEqual, which is a misnomer of its own (since it checks whether one method overrides the other and has a compatible return type, which is probably not what 'Equal' suggests). I would then propose to: - rename areMethodsEqual to areMethodsCompatible; - keep the existing areReturnTypesCompatible, - but implement a new method called bypassFurtherCompatibilityChecks that would introduce the nuance between method verifiers. Will post a patch along those lines.
Created attachment 62357 [details] Suggested fix After playing a bit with the code, I preferred to delegate part of the check to a worker method (suffixed by 0) when needed only. With this patch, areReturnTypesCompatible always returns immediately if types are identical, or else selectively (depending on compatibility levels) proceed with further checks. Kent, please let me know what you think.
Released for 3.3 M7.
Verified for 3.3M7 using I20070427-0010
