Bug 162321 - provide a new dtd file template <?xml version="1.0" encoding="UTF-8"?>
Summary: provide a new dtd file template <?xml version="1.0" encoding="UTF-8"?>
Status: CLOSED FIXED
Alias: None
Product: WTP Source Editing
Classification: WebTools
Component: wst.dtd (show other bugs)
Version: 1.5   Edit
Hardware: PC Windows XP
: P3 enhancement (vote)
Target Milestone: 3.0 M4   Edit
Assignee: Amy Wu CLA
QA Contact: Nitin Dahyabhai CLA
URL:
Whiteboard:
Keywords: bugday, contributed, helpwanted
Depends on:
Blocks:
 
Reported: 2006-10-25 17:24 EDT by Amy Wu CLA
Modified: 2008-04-24 00:45 EDT (History)
1 user (show)

See Also:


Attachments
Patch to add XML Declaration for New DTD file template (4.31 KB, patch)
2007-10-17 18:06 EDT, David Carver CLA
no flags Details | Diff
mylyn/context/zip (1.52 KB, application/octet-stream)
2007-10-17 18:06 EDT, David Carver CLA
no flags Details
Updated Patch for DTD Templates to include build.properties (2.55 KB, patch)
2007-11-30 09:02 EST, David Carver CLA
bjorn.freeman-benson: iplog+
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Amy Wu CLA 2006-10-25 17:24:15 EDT
We could at least provide a new dtd file template consisting of just:
<?xml version="1.0" encoding="${encoding}"?>
Comment 1 Amy Wu CLA 2007-09-18 13:23:18 EDT
This seems like an easy enough fix to put in for 3.0 and due to the change in UI, it needs to be done in a major release like 3.0, not in a service release.
Comment 2 David Carver CLA 2007-09-28 12:42:28 EDT
Should be able to leverage the existing XML Template for this, and have it also contribute to the DTD template.  I'll take a crack at this one.


Comment 3 David Carver CLA 2007-10-17 18:06:47 EDT
Created attachment 80616 [details]
Patch to add XML Declaration for New DTD file template

This patch will adds a New DTD file template that will create a initial DTD file with the XML declaration specified.   This also creates a file for other templates to be added to as well.
Comment 4 David Carver CLA 2007-10-17 18:06:48 EDT
Created attachment 80617 [details]
mylyn/context/zip
Comment 5 David Carver CLA 2007-10-17 18:08:34 EDT
Comment on attachment 80616 [details]
Patch to add XML Declaration for New DTD file template

corrected patch flag
Comment 6 Amy Wu CLA 2007-11-06 17:34:58 EST
patch looks good.  released for wtp 3.0 m3.  thanks, dave!
Comment 7 Amy Wu CLA 2007-11-09 00:50:23 EST
Reopening because i'm not seeing this template in the latest wtp 3.0 m3 build.
It looks like the build.properties file needs to be updated to include the newly created "templates" directory which is where the new template definition files are located.
Comment 8 David Carver CLA 2007-11-29 19:02:25 EST
Amy, I'll update the patch tomorrow.
Comment 9 David Carver CLA 2007-11-30 09:02:56 EST
Created attachment 84178 [details]
Updated Patch for DTD Templates to include build.properties

Updated patch to correctly include the templates directory during the build, so that it is exported to the jar.
Comment 10 Amy Wu CLA 2007-12-18 14:03:15 EST
Thanks for the updated patch. Released for this week's ibuild.
Comment 11 Amy Wu CLA 2008-01-04 18:47:26 EST
verified using wtp3.0M4 20080103204922
Comment 12 David Williams CLA 2008-04-24 00:45:28 EDT
mass change to add 'contributed' keyword based on bugzilla query, please correct if that's not accurate (by marking patches as obsolete and removing the 'contributed' keyword.