Bug 161980 - Make some member class static
Summary: Make some member class static
Status: VERIFIED FIXED
Alias: None
Product: JDT
Classification: Eclipse Project
Component: Core (show other bugs)
Version: 3.3   Edit
Hardware: PC Windows XP
: P3 normal (vote)
Target Milestone: 3.3 M4   Edit
Assignee: Olivier Thomann CLA
QA Contact:
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2006-10-23 12:54 EDT by Olivier Thomann CLA
Modified: 2006-12-12 13:48 EST (History)
0 users

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Olivier Thomann CLA 2006-10-23 12:54:23 EDT 
Some member classes that never referenced the enclosing type should be static. This would prevent the creation of the this$0 synthetic field.
Potential candidates:
org.eclipse.jdt.internal.eval.CodeSnippetSkeleton$BinaryMethodSkeleton
classe org.eclipse.jdt.internal.core.util.BindingKeyParser$Scanner
org.eclipse.jdt.internal.core.search.matching.MatchLocator$WrappedCoreException
org.eclipse.jdt.internal.core.JavaModelManager$CompilationParticipants
org.eclipse.jdt.internal.core.JavaElementDeltaBuilder$ListItem
org.eclipse.jdt.internal.core.index.DiskIndex$IntList
org.eclipse.jdt.internal.core.dom.rewrite.RewriteEventStore$PropertyLocation
org.eclipse.jdt.internal.compiler.parser.diagnose.LexStream$Token
org.eclipse.jdt.internal.compiler.parser.diagnose.DiagnoseParser$StateInfo
org.eclipse.jdt.internal.compiler.parser.diagnose.DiagnoseParser$SecondaryRepairInfo
org.eclipse.jdt.internal.compiler.parser.diagnose.DiagnoseParser$RepairCandidate
org.eclipse.jdt.internal.codeassist.CompletionEngine$AcceptedType
org.eclipse.jdt.core.search.SearchEngine$TypeNameRequestorAdapter
org.eclipse.jdt.core.search.SearchEngine$ResultCollectorAdapter
Comment 1 Olivier Thomann CLA 2006-11-23 20:38:13 EST 
Released for 3.3M4
Comment 2 Frederic Fusier CLA 2006-12-12 13:48:51 EST 
Verified for 3.3 M4 using build I20061212-0010.

Following inner classes are still not static:
org.eclipse.jdt.internal.eval.CodeSnippetSkeleton$BinaryMethodSkeleton
org.eclipse.jdt.core.search.SearchEngine$TypeNameRequestorAdapter
org.eclipse.jdt.core.search.SearchEngine$ResultCollectorAdapter

I guess this was intentional...